Skip to content

CodeQL docs: remove information about metric queries#3449

Merged
jf205 merged 2 commits intogithub:rc/1.24from
jf205:sd-38
May 12, 2020
Merged

CodeQL docs: remove information about metric queries#3449
jf205 merged 2 commits intogithub:rc/1.24from
jf205:sd-38

Conversation

@jf205
Copy link
Contributor

@jf205 jf205 commented May 12, 2020

Closes https://github.com/github/semmle-docs/issues/38.

Summary

Since metric queries are not really of interest in security (and the exisiting docs about metrics were a little sparse) all mentions of metrics should be removed.

Changes

Preview / current version source Change
About CodeQL queries / published version (source) Remove all mentions of metrics from text.
Metadata for CodeQL queries / published version (source) Deleted a table of properties that were only relevant to metric queries. Refactored various bits of. Updated a link about query tags to point to the Query metadata style guide instead of the LGTM help.
Defining the results of a query / published version (source) Delete mentions of metrics from text.

@jf205 jf205 marked this pull request as ready for review May 12, 2020 10:53
@jf205 jf205 requested a review from shati-patel as a code owner May 12, 2020 10:53
@jf205 jf205 removed the request for review from shati-patel May 12, 2020 10:53
shati-patel
shati-patel previously approved these changes May 12, 2020
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've highlighted one unrelated change, but otherwise 👍🏼

Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
@jf205 jf205 merged commit a6c03a4 into github:rc/1.24 May 12, 2020
@jf205 jf205 deleted the sd-38 branch May 15, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants