C++: Make path-problem versions of ir-flow.ql and flow.ql #3602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbj
previously approved these changes
Jun 2, 2020
Contributor
jbj
left a comment
jbj
left a comment
There was a problem hiding this comment.
I'd prefer code sharing instead of copy-pasting for the configuration pairs, but I'm okay with passing that burden on to the next person who changes the configuration.
Contributor
Author
Yeah, I just realized this is probably not the best way to do things. I've pushed a shared configuration now. |
jbj
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3463 replaced the
path-problemversions of ir-flow.ql and flow.ql with versions that useTestUtilities.InlineExpectationsTest.But as @jbj pointed out it's useful to see the graphs when debugging. So this PR re-introduces
path-problemversions of these two tests.