Skip to content

JS: Revert "Use guard nodes in useless-conditionals" #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
semmle-qlci merged 1 commit into from
Nov 1, 2018
Merged

JS: Revert "Use guard nodes in useless-conditionals" #388

semmle-qlci merged 1 commit into from
Nov 1, 2018

Conversation

@asger-semmle
Copy link
Contributor

@asger-semmle asger-semmle commented Oct 31, 2018

Reverts #380 - see discussion in that PR.

@asger-semmle
Revert "Merge pull request github#380 from asger-semmle/generalize-us…
2c11844 
…eless-conditional"

This reverts commit 28f3b68, reversing
changes made to dc3c5a6.
@asger-semmle asger-semmle requested a review from a team as a code owner October 31, 2018 10:40
@asger-semmle asger-semmle mentioned this pull request Oct 31, 2018
Merged
@semmle-qlci semmle-qlci merged commit a22aa35 into github:master Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@asger-semmle @semmle-qlci