Skip to content

Improve VariableAssign.getSource documentation #3920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aschackmull merged 1 commit into from
Jul 8, 2020
Merged

Improve VariableAssign.getSource documentation #3920

aschackmull merged 1 commit into from
Jul 8, 2020

Conversation

@Marcono1234
Copy link
Contributor

@Marcono1234 Marcono1234 commented Jul 7, 2020

Similarly to how Assignment.getSource describes what the "source" is, VariableAssign should probably explain it as well.

@Marcono1234 Marcono1234 requested a review from a team as a code owner July 7, 2020 20:39
aschackmull
aschackmull approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@aschackmull aschackmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aschackmull aschackmull merged commit b38839e into github:master Jul 8, 2020
@Marcono1234 Marcono1234 deleted the patch-3 branch July 8, 2020 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aschackmull aschackmull aschackmull approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Marcono1234 @aschackmull