address issue #4870, modify getParamName method to elimate false posi… #4872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e positive results
Contributor
|
@madneal Thanks for the report and the potential fix. I'm afraid the QL code is not the right place to address this issue. Instead it should be addressed in the "Java extractor". |
Contributor
Author
|
@aibaars Thanks for your reply. I'll close this pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tive results
I'm not sure if it's the best solution for the false positive results mentioned in #4870. As the method
getParamNameimpacts other queries. So I'd suggest to modify this method to elimate false positive results.