JS: Improve XMLParsers #5675
Merged
JS: Improve XMLParsers #5675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esbena
approved these changes
Apr 14, 2021
Contributor
esbena
left a comment
esbena
left a comment
There was a problem hiding this comment.
LGTM.
Some minor thoughts about potential FPs in a test case.
| sink(child.attr('foo').value()); // NOT OK | ||
|
|
||
| var child2 = xmlDoc.root().child() | ||
| sink(child2.attr('foo').name()); // NOT OK |
Contributor
There was a problem hiding this comment.
Hmm. This is equivalent to sink("foo"), which is safe.. But it is probably OK for us to get a FP in this silly case: why would you ever do .attr(x).name()?
A less silly variant, of this is attr.name() for a document that has been checked with a schema. But that is probably extremely rare in practice.
Contributor
Author
There was a problem hiding this comment.
You're right, the example is silly, nicely spotted.
I think it's fine to keep anyway. The .name() method generally returns tainted values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by CVE-2020-7750
I've refactored the libraries to use
API::Nodemore, and added models for the return values from more XML-parsing libraries.A simple evaluation looks OK.