C#: Add extraction error diagnostic query #5740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamasvajk
commented
Apr 21, 2021
csharp/ql/test/library-tests/diagnostics/DiagnosticExtractorErrors.expected
Outdated
Show resolved
Hide resolved
tamasvajk
commented
Apr 21, 2021
hvitved
reviewed
Apr 22, 2021
| } | ||
|
|
||
| from DiagnosticError error | ||
| select error.getMessage(), 3 |
Contributor
Author
There was a problem hiding this comment.
I think 3 means error in the SARIF format.
| file.fromSource() and | ||
| not exists(ExtractorError e | e.getLocation().getFile() = file) and | ||
| not exists(CompilerError e | e.getLocation().getFile() = file) | ||
| select file, "" |
Contributor
Author
There was a problem hiding this comment.
Yes, it is needed. This is probably how we indicate that these results are success ones. See also here.
hvitved
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two diagnostic queries to list extraction errors, and to list files with no extraction errors.
Additionally, it changes the standalone extractor to store extraction errors (model errors). This latter one (if approved) will need a change note.
Differences job