C++: Avoid using nullValue predicate (rc/1.19) #575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `nullValue` predicate performs a slow custom data-flow analysis to find possible null values. It's so slow that it timed out after 1200s on Wireshark. In `UnsafeCreateProcessCall.ql`, the values found with `nullValue` were used as sources in another data-flow analysis. By using the `NullValue` class as sink instead of `nullValue`, we avoid the slow-down of doing data flow twice. The `NullValue` class is essentially the base case of `nullValue`. Confusing names, yes.
geoffw0
approved these changes
Nov 30, 2018
Contributor
geoffw0
left a comment
geoffw0
left a comment
There was a problem hiding this comment.
LGTM. Improvement for me is 921s -> 741s, with the latter probably representing a lot of stuff that would be cached. bbSuccessorEntryReachesDefOrUse is no longer an expensive predicate. I couldn't find any real-world results to verify correctness, but the (fairly thorough) tests pass.
cklin
pushed a commit
that referenced
this pull request
May 23, 2022
Remove `CODEQL_REDUCE_FILES_FOLDERS_RELATIONS`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
nullValuepredicate performs a slow custom data-flow analysis to find possible null values. It's so slow that it timed out after 1200s on Wireshark.In
UnsafeCreateProcessCall.ql, the values found withnullValuewere used as sources in another data-flow analysis. By using theNullValueclass as sink instead ofnullValue, we avoid the slow-down of doing data flow twice. TheNullValueclass is essentially the base case ofnullValue. Confusing names, yes.I'll open the same PR for
ql:masterwhen this is merged.