Skip to content

Java: Use separate data-flow copy for PredictableSeedFlowConfiguration #5781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hvitved merged 1 commit into from
Apr 27, 2021
Merged

Java: Use separate data-flow copy for PredictableSeedFlowConfiguration #5781

hvitved merged 1 commit into from
Apr 27, 2021

Conversation

@hvitved
Copy link
Contributor

@hvitved hvitved commented Apr 27, 2021 •
edited
Loading

I noticed when running ExecUnescaped.ql that it needlessly evaluates PredictableSeedFlowConfiguration.

https://jenkins.internal.semmle.com/job/Changes/job/Java-Differences/1344/

@hvitved hvitved requested a review from a team as a code owner April 27, 2021 08:09
@github-actions github-actions bot added the Java label Apr 27, 2021
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Apr 27, 2021
@hvitved
Copy link
Contributor Author

hvitved commented Apr 27, 2021

I am going to ignore the warning that the DataFlow6 module lacks documentation, since that is also the case for all the other copies.

@hvitved hvitved merged commit 3737764 into github:main Apr 27, 2021
@hvitved hvitved deleted the java/predictable-seed-df6 branch April 27, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aschackmull aschackmull aschackmull approved these changes

Assignees

No one assigned

Labels

Java no-change-note-required This PR does not need a change note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hvitved @aschackmull