JS: add global replacements using inverted char classes as a sanitizer for DOM based XSS #5782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-krogh
added
the
Awaiting evaluation
erik-krogh
added
no-change-note-required
esbena
reviewed
Apr 27, 2021
| RegExp::alwaysMatchesMetaCharacter(getRegExp().getRoot(), ["<", "'", "\""]) | ||
| or | ||
| // or it's a global inverted char class. | ||
| getRegExp().getRoot().(RegExpCharacterClass).isInverted() |
Contributor
There was a problem hiding this comment.
Should we check which RegExpCharacterClass we are dealing with?
Contributor
Author
There was a problem hiding this comment.
Hmmm. Possibly yes.
I found the RegExp::isWildcardLike predicate, which I think matches nicely, so I refactored to use that predicate.
esbena
approved these changes
Apr 28, 2021
Contributor
Author
|
Another evaluation with the above changes also looks fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an FP I noticed in an internal project.
An evaluation was uneventful.
I don't think this requires a change-note, but let me know if you think this change needs one.