C++: add missing 1.19 change notes #589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I just sneaked a deprecation notice into this PR, along with a change note for it. There's unfortunately no way to deprecate a |
geoffw0
reviewed
Dec 3, 2018
change-notes/1.19/analysis-cpp.md
Outdated
| | Memory is never freed | Fewer false positive results | This query now accounts for C++ _placement new_, which returns a pointer that does not need to be freed. | | ||
| | Missing return statement (`cpp/missing-return`) | Visible by default | The precision of this query has been increased from 'medium' to 'high', which makes it visible by default in LGTM. It was 'medium' in release 1.17 and 1.18 because it had false positives due to an extractor bug that was fixed in 1.18. | | ||
| | Missing return statement | Fewer false positive results | The query is now produces correct results when a function returns a template-dependent type, or makes a non-returning call to another function. | | ||
| | Multiplication result converted to larger type (`cpp/integer-multiplication-cast-to-long`) | Fewer false positive results | Char-typed numbers are no longer considered to potentially large. | |
change-notes/1.19/analysis-cpp.md
Outdated
| | Missing return statement (`cpp/missing-return`) | Visible by default | The precision of this query has been increased from 'medium' to 'high', which makes it visible by default in LGTM. It was 'medium' in release 1.17 and 1.18 because it had false positives due to an extractor bug that was fixed in 1.18. | | ||
| | Missing return statement | Fewer false positive results | The query is now produces correct results when a function returns a template-dependent type, or makes a non-returning call to another function. | | ||
| | Multiplication result converted to larger type (`cpp/integer-multiplication-cast-to-long`) | Fewer false positive results | Char-typed numbers are no longer considered to potentially large. | | ||
| | Non-virtual destructor in base class (`cpp/virtual-destructor`) | Fewer false positive results | This query was renamed from "No virtual destructor" and moved from file name `AV Rule 78.ql` to `NonVirtualDestructorInBaseClass.ql`. The new version ignores base classes with non-public destructors since we consider those to be adequately protected. | |
Contributor
There was a problem hiding this comment.
I don't like the phrasing "renamed" and "moved" here as it suggests that AV Rule 78.ql no longer exists. I think we should say that it was "copied".
Contributor
Author
There was a problem hiding this comment.
I agree. I also find my explanation here to be more convoluted that it ought to be.
Contributor
Author
There was a problem hiding this comment.
I've attempted to update the explanation now. I made it more precise but possibly even more convoluted.
Contributor
|
👍 Presumably this needs a review from someone in @Semmle/doc. |
cklin
pushed a commit
that referenced
this pull request
May 23, 2022
Suites: Switch to the `queries` directive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, I think the change notes cover all the improvements we've made from 1.18 to 1.19. I've looked through all the PRs against this repo by myself, @dave-bartolomeo and @rdmarsh2 to see what was missing from the change notes.
The next step is that @felicity-semmle edits the change notes for consistency, language, etc.