Python: Fix CWE tag for py/use-of-input#6071
Merged
codeql-ci merged 1 commit intogithub:mainfrom Jun 21, 2021
Merged
Conversation
So it better matches what is in `py/code-injection`. I had my doubts about CWE-95, but after reading https://owasp.org/www-community/attacks/Direct_Dynamic_Code_Evaluation_Eval%20Injection I think it's fine to add CWE-95 as well 👍 Definitions are: CWE-78: Improper Neutralization of Special Elements used in an OS Command ('OS Command Injection') CWE-94: Improper Control of Generation of Code ('Code Injection') CWE-95: Improper Neutralization of Directives in Dynamically Evaluated Code ('Eval Injection')
RasmusWL
added
no-change-note-required
calumgrant
approved these changes
Jun 16, 2021
Contributor
calumgrant
left a comment
calumgrant
left a comment
There was a problem hiding this comment.
Overall I think the new tags make sense. I think that the reason you wanted to change this is because the original score (5.9) was too low, and your intuition would be correct. However, the way the algorithm was specified was using the CVE "impact score" which often gives quite low numbers. Like any heuristic, they can be off.
A new algorithm has been proposed to use the "base score" of the CVE, which gives higher numbers in general. In this case, the severity of the error goes from 9.8 to 9.3, both of which are "Critical" which feels right for this query.
tausbn
approved these changes
Jun 21, 2021
Member
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So it better matches what is in
py/code-injection. I had my doubts about CWE-95, but after readinghttps://owasp.org/www-community/attacks/Direct_Dynamic_Code_Evaluation_Eval%20Injection I think it's fine to add CWE-95 as well 👍
Definitions are:
CWE-78: Improper Neutralization of Special Elements used in an OS Command ('OS Command Injection')
CWE-94: Improper Control of Generation of Code ('Code Injection')
CWE-95: Improper Neutralization of Directives in Dynamically Evaluated Code ('Eval Injection')