Inline expectation tests: accept // $MISSING: and // $SPURIOUS:#6096
Merged
aschackmull merged 1 commit intogithub:mainfrom Jun 17, 2021
Merged
Conversation
Previously there had to be a space after the $ token, unlike ordinary expectations (i.e., // $xss was already accepted)
aschackmull
approved these changes
Jun 17, 2021
MathiasVP
approved these changes
Jun 17, 2021
Contributor
|
To be honest, I think it would be better to instead require a space after the |
Contributor
Author
|
By all means make that a style requirement, but let's not produce confusing errors due to whitespace fussiness. At the very least we should produce an error that points concretely to the problem, rather than misreporting the MISSING expectation as a regular one as at present |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously there had to be a space after the $ token, unlike ordinary expectations (i.e., // $xss was already accepted)
This is an improvement on the fix already shown in #6087 suggested by @aschackmull