1.19: Finalize change notes for JavaScript #619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That would be |
xiemaisi
suggested changes
Dec 6, 2018
xiemaisi
left a comment
xiemaisi
left a comment
There was a problem hiding this comment.
LGTM, thanks @felicity-semmle! A few minor suggestions.
| | File data in outbound network request | security, external/cwe/cwe-200 | Highlights locations where file data is sent in a network request. Results are not shown on LGTM by default. | | ||
| | Hard-coded data interpreted as code | security, external/cwe/cwe-506 | Highlights locations where hard-coded data is transformed and then executed as code or interpreted as an import path, which may indicate embedded malicious code ([CWE-506](https://cwe.mitre.org/data/definitions/506.html)). Results are not shown on LGTM by default. | | ||
| | Host header poisoning in email generation | security, external/cwe/cwe-640 | Highlights code that generates emails with links that can be hijacked by HTTP host header poisoning, indicating a violation of [CWE-640](https://cwe.mitre.org/data/definitions/640.html). Results shown on LGTM by default. | | ||
| | Enabling Node.js integration for Electron web content renderers (`js/enabling-electron-renderer-node-integration`) | security, frameworks/electron, external/cwe/cwe-094 | Highlights Electron web content renderer preferences with Node.js integration enabled, indicating a violation of [CWE-94](https://cwe.mitre.org/data/definitions/94.html). Results are hidden on LGTM by default. | |
There was a problem hiding this comment.
This query actually isn't even run on LGTM, so it should probably be moved to the "other new queries" section.
Add CWE reference. Co-Authored-By: felicity-semmle <felicity@semmle.com>
Add CWE reference Co-Authored-By: felicity-semmle <felicity@semmle.com>
Fix typo Co-Authored-By: felicity-semmle <felicity@semmle.com>
Contributor
Author
|
Thanks for the review and suggestions 😄 |
xiemaisi
approved these changes
Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prepares the JavaScript analysis change notes for inclusion in the help for LGTM Enterprise 1.19, and on help.semmle.com.
I've tried to put the edits and the text moves in separate commits:
There's one "TODO" - I wasn't sure which two the new queries now handle the dynamic method calls that are no longer flagged by Remote property injection (
js/remote-property-injection).@Semmle/js