Skip to content

C++: Rename "Incorrect 'not' operator usage" #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
felicitymay merged 1 commit into from
Dec 10, 2018
Merged

C++: Rename "Incorrect 'not' operator usage" #636

felicitymay merged 1 commit into from
Dec 10, 2018

Conversation

@jbj
Copy link
Contributor

@jbj jbj commented Dec 7, 2018

This makes the casing consistent with our other queries.

@jbj
C++: Rename "Incorrect 'not' operator usage"
00e52df 
This makes the casing consistent with our other queries.
@jbj jbj added the C++ label Dec 7, 2018
@jbj jbj added this to the 1.19 milestone Dec 7, 2018
@jbj jbj requested a review from felicitymay December 7, 2018 08:27
@jbj jbj requested a review from a team as a code owner December 7, 2018 08:27
geoffw0
geoffw0 approved these changes Dec 7, 2018
View reviewed changes
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@felicitymay
Copy link
Contributor

felicitymay commented Dec 10, 2018

Thanks.

@felicitymay felicitymay merged commit 882ab7e into github:rc/1.19 Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geoffw0 geoffw0 geoffw0 approved these changes

@felicitymay felicitymay Awaiting requested review from felicitymay

Assignees

No one assigned

Labels

C++

Projects

None yet

Milestone

1.19

Development

Successfully merging this pull request may close these issues.

3 participants

@jbj @felicitymay @geoffw0