Skip to content

Java: Fix FunctionalInterface. #6648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aschackmull merged 1 commit into from
Sep 9, 2021
Merged

Java: Fix FunctionalInterface. #6648

aschackmull merged 1 commit into from
Sep 9, 2021

Conversation

@aschackmull
Copy link
Contributor

@aschackmull aschackmull commented Sep 9, 2021

Fixes #3418

@aschackmull aschackmull added the no-change-note-required This PR does not need a change note label Sep 9, 2021
@aschackmull aschackmull requested a review from a team as a code owner September 9, 2021 13:05
@github-actions github-actions bot added the Java label Sep 9, 2021
bmuskalla
bmuskalla approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@bmuskalla bmuskalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

smowton
smowton approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@smowton smowton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Derived PR with a quick test I used to check getAnAbstractMethod's not exists clause did what I expected: #6651

@aschackmull aschackmull merged commit 13c4b93 into github:main Sep 9, 2021
@aschackmull aschackmull deleted the java/func-interface branch September 9, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smowton smowton smowton approved these changes

+1 more reviewer

@bmuskalla bmuskalla bmuskalla approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Java no-change-note-required This PR does not need a change note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Java: FunctionalInterface does not find all functional interfaces

3 participants

@aschackmull @smowton @bmuskalla