Java: Add deprecation notice to change notes. #677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felicitymay
reviewed
Dec 12, 2018
| been directly equatable to `Expr` and `Stmt`. Exploiting these equalities, | ||
| for example by using casts, is now deprecated, and the conversions | ||
| `Expr.getControlFlowNode()` and `Stmt.getControlFlowNode()` should be used | ||
| instead. |
Contributor
There was a problem hiding this comment.
Is it worth including an example of before and after, or is this obvious to users?
Contributor
Author
There was a problem hiding this comment.
This is mostly a warning about a breaking change we've agreed to put in 1.20, which we've convinced ourselves hopefully won't affect too many. The easiest is to just ignore the 1.19 deprecation and fix any compile errors when upgrading to 1.20, so we'll add more information in the 1.20 change notes.
Contributor
There was a problem hiding this comment.
Okay - makes sense. I've raised https://jira.semmle.com/browse/SD-2920 for the changes required to publish this change for 1.19.
felicitymay
approved these changes
Dec 12, 2018
cklin
pushed a commit
that referenced
this pull request
May 23, 2022
Release preparation for version 2.8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last minute addition to the change notes.
@pavgust @felicity-semmle