Skip to content

C++: Fix name clash in data flow imports #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adityasharad merged 1 commit into from
Dec 13, 2018
Merged

C++: Fix name clash in data flow imports #681

adityasharad merged 1 commit into from
Dec 13, 2018

Conversation

@jbj
Copy link
Contributor

@jbj jbj commented Dec 13, 2018

The AST-based data flow libraries and the IR-based ones both define modules DataFlow, DataFlow2, etc. This caused ImportAdditionalLibraries.ql to fail in compilation.

@jbj
C++: Fix name clash in data flow imports
1a0a8c9 
The AST-based data flow libraries and the IR-based ones both define
modules `DataFlow`, `DataFlow2`, etc. This caused
`ImportAdditionalLibraries.ql` to fail in compilation.
@jbj jbj added the C++ label Dec 13, 2018
@jbj jbj added this to the 1.19 milestone Dec 13, 2018
@jbj jbj requested a review from a team as a code owner December 13, 2018 09:56
@geoffw0
Copy link
Contributor

geoffw0 commented Dec 13, 2018

The description of ImportAdditionalLibraries.ql says it "imports some libraries we would like to make available in the LGTM query console even if they are not used by any queries." Does the module statement around the import affect the way LGTM users access these additional libraries?

@jbj
Copy link
Contributor Author

jbj commented Dec 13, 2018

@geoffw0 ImportAdditionalLibraries.ql is only there to introduce file-level dependencies on otherwise unused qll files. No names in it are visible to anything else.

geoffw0
geoffw0 approved these changes Dec 13, 2018
View reviewed changes
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@adityasharad adityasharad merged commit fb82811 into github:rc/1.19 Dec 13, 2018
@jbj
Copy link
Contributor Author

jbj commented Dec 13, 2018

Cc @dave-bartolomeo. I've opened https://git.semmle.com/Semmle/code/pull/29761 to prevent this from happening again.

cklin pushed a commit that referenced this pull request May 23, 2022
@owen-mc
Merge pull request #681 from owen-mc/new-query/wrapped-error-always-nil
980c274 
Add query "Wrapped error always nil"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityasharad adityasharad adityasharad approved these changes

@geoffw0 geoffw0 geoffw0 approved these changes

Assignees

No one assigned

Labels

C++

Projects

None yet

Milestone

1.19

Development

Successfully merging this pull request may close these issues.

3 participants

@jbj @geoffw0 @adityasharad