Skip to content

Conversation

@asger-semmle
Copy link
Contributor

Adds support for new features in TypeScript 3.0, in the AST and type system:

  • unknown type
  • tuples with optional elements, e.g. [number, string?]
  • tuples with rest elements, e.g. [number, ...string[]]

Should land in tandem with extractor changes.

@asger-semmle asger-semmle requested a review from a team as a code owner August 20, 2018 15:38
xiemaisi
xiemaisi previously approved these changes Aug 21, 2018
Copy link

@xiemaisi xiemaisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The typo fix can be done separately to avoid complicating the merge.

* An optional type element in a tuple type, such as `number?` in `[string, number?]`.
*/
class OptionalTypeExpr extends @optionaltypeexpr, TypeExpr {
/** Gets the type `T` in `T?` */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing full stop.

@xiemaisi
Copy link

Extractor PR has been merged.

@xiemaisi xiemaisi merged commit 1aa7a2c into github:master Aug 22, 2018
aibaars pushed a commit that referenced this pull request Oct 14, 2021
Updates after CodeQL upgrade to 2.4.1
smowton pushed a commit to smowton/codeql that referenced this pull request Dec 6, 2021
erik-krogh pushed a commit to erik-krogh/ql that referenced this pull request Dec 15, 2021
erik-krogh pushed a commit to erik-krogh/ql that referenced this pull request Dec 15, 2021
…stnode

Refactor Call.getTarget to be an AstNode
dbartol pushed a commit that referenced this pull request Dec 18, 2024
Add models for list-files actions
MathiasVP pushed a commit to MathiasVP/ql that referenced this pull request Aug 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants