Detect usage of ICryptoTransform that would be thread-unsafe #956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t ICryptoTransform that would be thread-unsafe, and potentially result in incorrect cryptographic results.
hvitved
requested changes
Feb 22, 2019
Contributor
hvitved
left a comment
hvitved
left a comment
There was a problem hiding this comment.
Thank you very much for your contribution @raulgarciamsft, this is great stuff. I have a couple of comments, let me know what you think.
hvitved
requested changes
Feb 27, 2019
Contributor
hvitved
left a comment
hvitved
left a comment
There was a problem hiding this comment.
Just one more thing, and then I'm happy.
jf205
reviewed
Feb 27, 2019
Contributor
jf205
left a comment
jf205
left a comment
There was a problem hiding this comment.
Hi @raulgarciamsft.
I have reviewed the qhelp file on behalf of the Semmle documentation team.
I've made a few suggestions on how I think it could be improved - hopefully they don't change the intended meaning.
Let me know if you have any questions.
Thanks!
Contributor
|
The updated documentation LGTM. Thanks. |
hvitved
approved these changes
Mar 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new rule for detecting usage of static objects that implement ICryptoTransform that would be thread-unsafe, and potentially result in incorrect cryptographic results.