JS: track flow through class fields in some cases #989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiemaisi
reviewed
Mar 1, 2019
xiemaisi
left a comment
xiemaisi
left a comment
There was a problem hiding this comment.
General approach looks good, but I'll wait for evaluation results before approving.
Contributor
Author
|
Evaluation shows some perf issues. I suspect the new exploratory flow steps are to blame, but I'll investigate further after feature freeze. |
asger-semmle
force-pushed
the
class-node-get-this-access
branch
from
ccc499f to
9497199
Compare
Contributor
Author
|
@xiemaisi PTAL. I have removed the last commit which added the data flow step to our default suite. I'll try and land it later. For now, only the commits that add These should not have any impact on perf, but I've re-run the evaluation on the slowest projects from the prior revaluation just as a sanity check. |
xiemaisi
approved these changes
Mar 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revives a part of #760: field flow directly from constructors to instance members.
This avoids the potential for FPs by restricting the flow to cases where the flow source is in the constructor or one of its callees, as opposed to coming in through a parameter.
It also adds
DataFlow::localFieldStepto make it easier for custom queries to relax the above constraint and track things freely through fields.