Skip to content

Unify @github/copilot version tracking and rename sync workflow#139

Merged
edburns merged 4 commits intomainfrom
edburns/fix-gap-with-package_json
Apr 30, 2026
Merged

Unify @github/copilot version tracking and rename sync workflow#139
edburns merged 4 commits intomainfrom
edburns/fix-gap-with-package_json

Conversation

@edburns
Copy link
Copy Markdown
Collaborator

@edburns edburns commented Apr 30, 2026

Problem:
Two independent paths updated the @github/copilot dependency:

  1. Dependabot bumped scripts/codegen/package.json (for schema codegen)
  2. The weekly reference-impl sync updated pom.xml (for CLI test binary)

These could drift apart, causing schema/CLI version mismatches.

Solution (Option C):
Make the reference-impl sync the single entry point for all @github/copilot
version changes. During sync, both pom.xml AND scripts/codegen/package.json
are updated from the reference implementation's nodejs/package.json.

Changes:

  1. New script: sync-codegen-version.sh

    • Extracts @github/copilot version from reference impl
    • Runs npm install in scripts/codegen/ to update package.json and lock file
  2. Updated merge-reference-impl-finish.sh

    • Calls sync-codegen-version.sh after the existing pom.xml sync
    • Stages scripts/codegen/package.json and package-lock.json in the commit
  3. Removed Dependabot npm entry for /scripts/codegen

    • No longer needed since the reference-impl sync handles this dependency
  4. Renamed workflow files (removed timing from names):

    • weekly-reference-impl-sync.yml -> reference-impl-sync.yml
    • weekly-reference-impl-sync.md -> reference-impl-sync.md
    • weekly-reference-impl-sync.lock.yml -> reference-impl-sync.lock.yml
  5. Changed schedule from weekly (Monday) to daily

  6. Removed all "weekly"/"Weekly" timing references from:

    • Workflow files (.yml, .md, .lock.yml)
    • POM property name (removed "weekly" from the long property name)
    • setup-copilot/action.yml
    • sync-cli-version-from-reference-impl.sh
    • coding-agent-merge-reference-impl-instructions.md
    • README.md
    • docs/WORKFLOWS.md
  7. Recompiled agentic workflow lock file via gh aw compile

edburns added 2 commits April 29, 2026 23:34
Option C: Make reference-impl sync the single entry point for all
@github/copilot version changes. During sync, both pom.xml and
scripts/codegen/package.json are updated from the reference
implementation's nodejs/package.json.

Changes:
- Add sync-codegen-version.sh to update scripts/codegen/package.json
- Update merge-reference-impl-finish.sh to call the new script
- Remove Dependabot npm entry for /scripts/codegen (no longer needed)
- Rename weekly-reference-impl-sync.{yml,md,lock.yml} to
  reference-impl-sync.{yml,md,lock.yml}
- Change schedule from weekly (Monday) to daily
- Remove all 'weekly'/'Weekly' timing references from file contents
- Rename POM property to remove 'weekly' from its name
- Recompile agentic workflow via gh aw compile
Option C: Make reference-impl sync the single entry point for all
@github/copilot version changes. During sync, both pom.xml and
scripts/codegen/package.json are updated from the reference
implementation's nodejs/package.json.

Changes:
- Add sync-codegen-version.sh to update scripts/codegen/package.json
- Update merge-reference-impl-finish.sh to call the new script
- Remove Dependabot npm entry for /scripts/codegen (no longer needed)
- Rename weekly-reference-impl-sync.{yml,md,lock.yml} to
  reference-impl-sync.{yml,md,lock.yml}
- Change schedule from weekly (Monday) to daily
- Remove all 'weekly'/'Weekly' timing references from file contents
- Rename POM property to remove 'weekly' from its name
- Recompile agentic workflow via gh aw compile
Copy link
Copy Markdown
Collaborator Author

@edburns edburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot authored.

AgentInfo record gained a 'path' field in the generated code. Update
GeneratedRpcRecordsCoverageTest to pass the 4th parameter in all
constructor calls.
@edburns edburns marked this pull request as ready for review April 30, 2026 04:24
Copilot AI review requested due to automatic review settings April 30, 2026 04:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to make the reference-implementation sync the single mechanism for keeping the @github/copilot version aligned across the Java SDK’s test CLI (via pom.xml) and schema/codegen tooling (via scripts/codegen/package.json), while also renaming and de-“weekly”-ifying the reference sync workflow and related docs.

Changes:

  • Add a new sync script to update scripts/codegen’s @github/copilot dependency from the reference implementation, and invoke it from the merge finish script.
  • Rename the reference-impl sync workflows/files and update schedule/text references across docs and scripts.
  • Remove Dependabot’s npm updater for /scripts/codegen.
Show a summary per file
File Description
src/test/java/com/github/copilot/sdk/generated/rpc/GeneratedRpcRecordsCoverageTest.java Updates tests for the new AgentInfo shape (adds path).
pom.xml Renames the readonly @github/copilot tracking property to remove “weekly” from the name.
docs/WORKFLOWS.md Updates workflow names/links for the renamed reference sync workflows.
README.md Updates the description/linking for the renamed sync workflow and mentions lockstep versioning.
.github/workflows/reference-impl-sync.yml Renames the workflow and changes its cron schedule.
.github/workflows/reference-impl-sync.md Renames the agentic workflow source prompt and updates schedule metadata.
.github/workflows/reference-impl-sync.lock.yml Recompiled compiled agentic workflow with updated naming/schedule.
.github/scripts/reference-impl-sync/sync-codegen-version.sh New script to sync scripts/codegen @github/copilot version from reference impl.
.github/scripts/reference-impl-sync/sync-cli-version-from-reference-impl.sh Updates property name references to match the renamed pom property.
.github/scripts/reference-impl-sync/merge-reference-impl-finish.sh Calls the new codegen sync script and stages codegen package/lock updates.
.github/prompts/coding-agent-merge-reference-impl-instructions.md Updates workflow filename references after rename.
.github/dependabot.yml Removes npm updates for /scripts/codegen.
.github/actions/setup-copilot/action.yml Updates the pom property name used to read the pinned @github/copilot version.

Copilot's findings

Comments suppressed due to low confidence (1)

.github/workflows/reference-impl-sync.yml:6

  • The workflow schedule here is Tuesday/Thursday (cron 0 10 * * 2,4), but the PR description and the agentic workflow metadata indicate the sync was changed to daily. Please align the schedule across the non-agentic workflow, the agentic workflow, and docs/PR description (either make this cron daily, or update the other references to match Tue/Thu).
  • Files reviewed: 12/13 changed files
  • Comments generated: 3

Comment thread .github/scripts/reference-impl-sync/merge-reference-impl-finish.sh Outdated
Comment thread .github/scripts/reference-impl-sync/sync-codegen-version.sh Outdated
Comment thread docs/WORKFLOWS.md Outdated
…S.md links and add codegen-only note

Agent-Logs-Url: https://github.com/github/copilot-sdk-java/sessions/d68264a5-52bb-497f-bca0-5ef13a7efdec

Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
@edburns edburns merged commit 3d54be7 into main Apr 30, 2026
10 checks passed
@edburns edburns deleted the edburns/fix-gap-with-package_json branch April 30, 2026 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants