Skip to content

fix(dotnet): add AgentId to SessionEvent base class #1181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
IeuanWalker wants to merge 2 commits into from
+44 −0
Closed

fix(dotnet): add AgentId to SessionEvent base class #1181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d46173
fix(dotnet): add AgentId to SessionEvent base class
IeuanWalker Apr 30, 2026
cb89b9b
Add Tests
IeuanWalker Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions dotnet/src/Generated/SessionEvents.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

37 changes: 37 additions & 0 deletions dotnet/test/ForwardCompatibilityTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,4 +97,41 @@ public void SessionEvent_Type_DefaultsToUnknown()

Assert.Equal("unknown", evt.Type);
}

[Fact]
public void FromJson_WithAgentId_DeserializesAgentId()
{
var json = """
{
"id": "12345678-1234-1234-1234-123456789abc",
"timestamp": "2026-06-15T10:30:00Z",
"parentId": null,
"agentId": "sub-agent-42",
"type": "future.feature_from_server",
"data": {}
}
""";

var result = SessionEvent.FromJson(json);

Assert.Equal("sub-agent-42", result.AgentId);
}

[Fact]
public void FromJson_WithoutAgentId_AgentIdIsNull()
{
var json = """
{
"id": "12345678-1234-1234-1234-123456789abc",
"timestamp": "2026-06-15T10:30:00Z",
"parentId": null,
"type": "future.feature_from_server",
"data": {}
}
""";

var result = SessionEvent.FromJson(json);

Assert.Null(result.AgentId);
}
}
2 changes: 2 additions & 0 deletions scripts/codegen/csharp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -739,6 +739,8 @@ namespace GitHub.Copilot.SDK;
lines.push(` [JsonPropertyName("parentId")]`, ` public Guid? ParentId { get; set; }`, "");
lines.push(...xmlDocComment(baseDesc("ephemeral"), " "));
lines.push(` [JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)]`, ` [JsonPropertyName("ephemeral")]`, ` public bool? Ephemeral { get; set; }`, "");
lines.push(...xmlDocComment(baseDesc("agentId"), " "));
lines.push(` [JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)]`, ` [JsonPropertyName("agentId")]`, ` public string? AgentId { get; set; }`, "");
lines.push(` /// <summary>`, ` /// The event type discriminator.`, ` /// </summary>`);
lines.push(` [JsonIgnore]`, ` public virtual string Type => "unknown";`, "");
lines.push(` /// <summary>Deserializes a JSON string into a <see cref="SessionEvent"/>.</summary>`);
Expand Down