Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for a custom configuration directory (config_dir/configDir) option to session creation across all four SDKs (Python, Node.js, Go, and .NET). This enables users to isolate session configuration and state in a custom directory location instead of using the default.
Changes:
- Added
config_dir/configDirfield to session configuration types in all SDKs - Updated session creation logic to pass the config directory to the underlying session.create RPC call
- Added E2E tests for all four SDKs to verify sessions work correctly with custom config directories
- Added snapshot file for the new test case
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/snapshots/session/should_create_session_with_custom_config_dir.yaml | Snapshot file for the new test case verifying session creation with custom config directory |
| python/e2e/test_session.py | Added E2E test to verify session creation with custom config directory in Python SDK |
| python/copilot/types.py | Added config_dir field to SessionConfig type with documentation |
| python/copilot/client.py | Added logic to pass config_dir to session.create RPC call |
| nodejs/test/e2e/session.test.ts | Added E2E test to verify session creation with custom config directory in Node.js SDK |
| nodejs/src/types.ts | Added configDir field to SessionConfig interface with JSDoc documentation |
| nodejs/src/client.ts | Added logic to pass configDir to session.create RPC call |
| go/types.go | Added ConfigDir field to SessionConfig struct with documentation |
| go/e2e/session_test.go | Added E2E test to verify session creation with custom config directory in Go SDK |
| go/client.go | Added logic to pass configDir to session.create RPC call |
| dotnet/test/SessionTests.cs | Added E2E test to verify session creation with custom config directory in .NET SDK |
| dotnet/src/Types.cs | Added ConfigDir property to SessionConfig class with XML documentation |
| dotnet/src/Client.cs | Added ConfigDir parameter to CreateSessionRequest record and updated session creation logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
46a9156 to
26a732f
Compare
criemen
left a comment
There was a problem hiding this comment.
stamping for merge conflict resolution
26a732f to
9d4fb55
Compare
|
@devm33 You've got some CI failures here |
Yes this is blocked by a change in the runtime to fix connecting the config dir setting |
|
@devm33 You might need to rebase on main to inherit test fixes. (Edit: oh maybe you already did merge it in) |
6f5bd37 to
5c0b6e9
Compare
done! |
Enables setting an isolated configuration per session. Added to all SDKs.