Cleanup Go Client implementation

[qmuntal]

This pull request refactors the client connection handling and URL parsing logic for improved clarity, reliability, and type safety. The main changes include stricter typing for the connection field, a more robust and readable parseCliUrl function, and simplifications in connection closing logic. Additionally, error handling in tool execution and related tests have been improved.

[qmuntal]

CI will be green once #319 lands.

[Copilot]

Pull request overview

This pull request refactors the Go client implementation to improve type safety, code clarity, and maintainability. The changes focus on connection handling, URL parsing, and error handling without altering external behavior.

Changes:

• Strengthened type safety by changing the connection field from any to net.Conn
• Simplified URL parsing logic using standard library string functions instead of regex
• Streamlined connection closing by removing unnecessary type assertions
• Improved error handling scope in tool execution

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
go/client.go	Refactored connection field typing, URL parsing logic, connection cleanup code, and tool execution error handling
go/client_test.go	Updated test expectations to match refined error messages from URL parsing changes

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

✅ Cross-SDK Consistency Review: PASSED

I've reviewed PR #321 for cross-SDK consistency across Node.js/TypeScript, Python, Go, and .NET implementations. This refactoring maintains and improves consistency with the following patterns:

Changes Reviewed

1. Type Safety Enhancement (conn: any → conn: net.Conn)

   • ✅ GOOD: Aligns with Node.js/TypeScript (Socket | null) and .NET (TcpClient?) which use strong typing
   • ✅ IMPROVEMENT: Python uses custom SocketWrapper which is loosely coupled - Go now matches best practices

2. URL Parsing Refactor (regex → native string methods)

   • ✅ GOOD: Matches .NET pattern which uses int.TryParse(), .StartsWith(), and Uri class - NO regex
   • ✅ IMPROVED READABILITY: Using strings.CutPrefix() and strings.Cut() is cleaner than regex compilation
   • ℹ️ Note: Node.js still uses regex, but .NET and Go now share native string parsing approach

3. Connection Close Simplification (type assertion removed)

   • ✅ GOOD: Direct c.conn.Close() call is simpler since conn is now strongly typed as net.Conn
   • ✅ CONSISTENT: All SDKs have straightforward close logic without type checks

4. Tool Execution Error Handling

   • ✅ EXCELLENT: Removed fmt.Printf() logging before building failed result
   • ✅ CONSISTENT: All SDKs (Node.js, Python, .NET) build error results directly without pre-logging
   • ✅ PROPER SCOPING: Error variable now scoped inside handler block like other SDKs

Feature Parity Status

All four SDKs maintain consistent:

• ✅ TCP connection management (stdio + external server modes)
• ✅ URL/port parsing (supports host:port, (host/redacted) (host/redacted):port, or just port`)
• ✅ Error collection and handling patterns
• ✅ Connection lifecycle management (Start/Stop/ForceStop)

Summary

This PR is a pure internal refactoring that improves code quality, type safety, and readability while maintaining full consistency with the SDK ecosystem. The changes actually bring Go closer to .NET's native string parsing approach and align error handling with all other SDKs.

No action required on other SDKs. This cleanup is Go-specific and maintains API compatibility.

AI generated by SDK Consistency Review Agent