Add missing options to ResumeSessionConfig for parity with create#376
Add missing options to ResumeSessionConfig for parity with create#376
Conversation
- Add model, systemMessage, availableTools, excludedTools, configDir, and infiniteSessions to resume session config in all SDKs - Update client implementations to pass new options to server - Add "Resume Options" documentation section - Bump @github/copilot dependency to ^0.0.403
✅ Cross-SDK Consistency Review: PASSEDThis PR demonstrates excellent cross-SDK consistency. All four SDK implementations (Node.js, Python, Go, and .NET) have been updated uniformly to add the same set of resume session options. Verified ConsistencyAdded options to
Implementation details:
Additional NotesThe PR also bumps the No consistency issues found. 🎉
|
There was a problem hiding this comment.
Pull request overview
This PR adds missing configuration options to ResumeSessionConfig across all SDKs (Node/TS, Python, Go, .NET) to achieve feature parity with CreateSessionConfig. The changes allow developers to modify session settings when resuming, such as changing the model, updating tool configurations, or adjusting system messages. The PR also bumps the @github/copilot dependency to version 0.0.403 and adds comprehensive documentation for the new resume options.
Changes:
- Added
model,systemMessage,availableTools,excludedTools,configDir, andinfiniteSessionsoptions toResumeSessionConfigin all SDKs - Updated client implementations to pass new options to the server during session resume
- Added "Resume Options" documentation section with examples
- Bumped
@github/copilotdependency from ^0.0.402 to ^0.0.403
Reviewed changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/harness/package.json | Bumped @github/copilot dependency to ^0.0.403 |
| test/harness/package-lock.json | Updated lock file with new dependency versions |
| python/copilot/types.py | Added new fields to ResumeSessionConfig type definition |
| python/copilot/client.py | Implemented handling for new resume options (contains bug in system_message handling) |
| nodejs/src/types.ts | Extended ResumeSessionConfig to include new options via Pick type |
| nodejs/src/client.ts | Updated resumeSession to pass new options to server |
| nodejs/package.json | Bumped @github/copilot dependency to ^0.0.403 |
| nodejs/package-lock.json | Updated lock file with new dependency versions |
| go/types.go | Added new fields with documentation to ResumeSessionConfig struct |
| go/client.go | Implemented handling for new resume options including SystemMessage serialization |
| dotnet/src/Types.cs | Added new properties with XML documentation to ResumeSessionConfig class |
| dotnet/src/Client.cs | Updated ResumeSessionAsync and ResumeSessionRequest to include new options |
| docs/guides/session-persistence.md | Added "Resume Options" section with table and examples |
Files not reviewed (2)
- nodejs/package-lock.json: Language not supported
- test/harness/package-lock.json: Language not supported
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
✅ Cross-SDK Consistency ReviewI've reviewed this PR for consistency across all four SDK implementations (Node.js/TypeScript, Python, Go, and .NET), and I'm pleased to report that this PR maintains excellent cross-language consistency. Summary of ChangesThis PR adds missing options to
✅ Consistency VerificationAll four SDKs have been updated consistently:
🎯 API Naming ConsistencyThe implementations properly respect language conventions:
📚 DocumentationThe PR also includes comprehensive documentation in 🔍 Implementation QualityAll four implementations correctly:
No cross-SDK consistency issues found. 🎉
|
and infiniteSessions to resume session config in all SDKs