Skip to content

Fix escape issue in client.ts #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SteveSandersonMS merged 1 commit into from
Jan 20, 2026
Merged

Fix escape issue in client.ts #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nodejs/src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -724,7 +724,7 @@ export class CopilotClient {
} else if (process.platform === "win32" && !isAbsolutePath) {
// On Windows, spawn doesn't search PATHEXT, so use cmd /c to resolve the executable.
command = "cmd";
spawnArgs = ["/c", `"${this.options.cliPath}"`, ...args];
spawnArgs = ["/c", `${this.options.cliPath}`, ...args];
} else {
command = this.options.cliPath;
spawnArgs = args;
Comment on lines 724 to 730
Copy link

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Windows-specific spawn behavior lacks test coverage. Consider adding a test case that verifies the spawn arguments are correctly constructed for non-absolute paths on Windows, especially since this code path is platform-specific and was previously broken.

Copilot uses AI. Check for mistakes.
Expand Down
Loading