Fix issue-triage workflow to add labels via add-labels safe-output#6
Merged
Fix issue-triage workflow to add labels via add-labels safe-output#6
Conversation
Co-authored-by: friggeri <106686+friggeri@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue triage to add missing labels
Fix issue-triage workflow to add labels via add-labels safe-output
Jan 14, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the issue triage workflow to enable label addition functionality by adding the add-labels safe-output configuration, which was missing from the original workflow setup.
Changes:
- Added
add-labelssafe-output configuration to the issue triage workflow with 14 allowed labels - Updated compiled lock file to reflect the new safe-output configuration
- Enabled the AI agent to add labels to issues during triage
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/issue-triage.md |
Added add-labels safe-output configuration with allowed labels list and max/target settings |
.github/workflows/issue-triage.lock.yml |
Compiled workflow file reflecting the new add-labels configuration in multiple locations (config.json, tools.json, validation.json, and handler config) |
Comments suppressed due to low confidence (1)
.github/workflows/issue-triage.md:15
- While the workflow-level permissions are correctly set (they don't need
issues: writesince thesafe_outputsjob handles that), it would be helpful to add a comment explaining whyissues: writeis not included here. This would prevent future confusion about how labels can be added without write permissions. Consider adding a comment like:# Note: issues:write not needed - handled by safe_outputs job.
permissions:
contents: read
issues: read
pull-requests: read
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SteveSandersonMS
approved these changes
Jan 14, 2026
jmoseley
approved these changes
Jan 14, 2026
jmoseley
pushed a commit
that referenced
this pull request
Jan 21, 2026
tclem
added a commit
that referenced
this pull request
Apr 30, 2026
Closes RFD-400 review finding #6 (per-method cancel-safety documentation). Doc-only follow-up to commits A/B/C; no behavioral change. RFD 400 § "Marking APIs as cancel-unsafe" calls for explicit documentation; with the underlying behavior now correct after A/B/C, documenting the contract makes it inspectable from rustdoc rather than requiring callers to read the implementation. Added `# Cancel safety` rustdoc sections to: - `Session::send` — cancel-safe (writer-actor); message lands on the wire even if the await is cancelled. - `Session::send_and_wait` — cancel-safe (WaiterGuard RAII); outer-cancellation distinct from internal-timeout, both clear the slot. - `Session::abort` — cancel-safe (single RPC via writer-actor). - `Client::call` — cancel-safe at the wire level; documents the caveat that the CLI may still process the request even if the caller doesn't see the response (idempotent vs non-idempotent methods). - `Client::stop` — cancel-unsafe-but-recoverable; the body sequentially destroys sessions (each individually cancel-safe) before killing the child. The existing `tokio::time::timeout` example with `force_stop` fallback is the documented recovery path. - `Client::force_stop` — synchronous, cannot be cancelled. Designed as the recovery path for `stop`'s timeout case. - `Subscription::recv` — cancel-safe by virtue of `tokio::sync::broadcast` + `BroadcastStream`. Validation: cargo doc -D warnings clean, cargo test (215 pass), cargo +nightly fmt --check clean, cargo clippy clean. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue-triage workflow claimed to add labels in comments but labels were never applied to issues.
Root Cause
Workflow configured
update-issuesafe-output, which only supports status/title/body updates—not labels.Changes
add-labelssafe-output configuration with all 14 labels from the workflow promptmax: 10andtarget: triggeringto allow multiple labels per triggering issueWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/github/copilot-sdk/labels/usr/bin/curl curl -s -H Accept: application/vnd.github+json REDACTED(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.