-
Notifications
You must be signed in to change notification settings - Fork 65.5k
Adds the raw powershell equivalents for github actions commands #15354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
|
@jessehouwing |
fullofhope336
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
``
|
@jessehouwing -- Thanks for the feedback!
We don't currently have a way to correctly render multiple languages within the same codeblock 🤔 We're finding that the codeblock titles for "Shell" and "PowerShell" are useful for letting us distinguish them, and saves us from having to keep each example in a separate subsection -- this would occupy a lot more screen space and make it difficult for users to scan through the content.
I've added intro text for each of these examples, to make it clearer which version is being referenced. Unfortunately our docs site doesn't let us easily add new languages. |
|
Status update: docs engineering are investigating the staging issue |
Looks like your commit fixed it 😄 🎊 |
|
Following up on the content plan consideration described here: #15354 (comment) |
Thanks @emilyistoofunky, I've added the reasoning for the two new tools to @skedwards88's issue 👍 |
|
This is looking ready to ship 🚢 🎊 Just doing some final checks. |
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
|
@jessehouwing - Thanks again for this great PR, PowerShell users are definitely going to appreciate this update ✨ |
|
Changes are now live: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions ⚡ |



Closes: #15355
Why:
The default shell on Windows ir now
pwsh, all of the examples are only forbash. And there are a few caveats.Ideally the page would be rplit across technology
[bash, pwsh, powershell, javascript]and not[linux, mac, windows]cause, likebash,pwshis also available on all platforms. I couldn't find how to easily make a tech selector for things other thantargetPlatform.What's being changed:
This adds a
pwshexample to each place where action command examples are shown inbash.Staging preview:
Check off the following:
Work in progress