Skip to content

Fixed matrix.dotnet-version key #15550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lucascosti merged 2 commits into from
Feb 25, 2022
Merged

Fixed matrix.dotnet-version key #15550

lucascosti merged 2 commits into from
Feb 25, 2022
+1 −1

Conversation

@weineran
Copy link
Contributor

@weineran weineran commented Feb 16, 2022

Changed matrix.dotnet key to matrix.dotnet-version

Why:

There was a small bug in the docs.

What's being changed:

Changed matrix.dotnet key to matrix.dotnet-version

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@weineran
Fixed matrix.dotnet-version key
fc198b7 
Changed `matrix.dotnet` key to `matrix.dotnet-version`
@welcome
Copy link

welcome bot commented Feb 16, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 16, 2022
@ramyaparimi ramyaparimi added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Feb 17, 2022
@ramyaparimi
Copy link
Contributor

ramyaparimi commented Feb 17, 2022

@weineran
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@weineran
Copy link
Contributor Author

weineran commented Feb 23, 2022

@weineran Thanks so much for opening a PR! I'll get this triaged for review ⚡

@ramyaparimi No problem! It's a super short review, but let me know if there are any questions/comments/concerns.

lucascosti
lucascosti approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this fix, @weineran! I'll get this merged 🚀

@lucascosti lucascosti enabled auto-merge (squash) February 25, 2022 05:41
@lucascosti lucascosti merged commit 96bf129 into github:main Feb 25, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lucascosti lucascosti lucascosti approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@weineran @ramyaparimi @lucascosti