Skip to content

Conversation

@taleleuma
Copy link
Contributor

@taleleuma taleleuma commented Feb 25, 2022

sudo command is applicable to Linux only. Doesn't work on windows.

Why:

Closes [issue link]

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

sudo command is applicable to Linux only. Doesn't work on windows.
@welcome
Copy link

welcome bot commented Feb 25, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 25, 2022
@ramyaparimi ramyaparimi added authentication Content relating to authentication content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Feb 25, 2022
@ramyaparimi
Copy link
Contributor

@taleleuma
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@vgrl vgrl self-assigned this Mar 1, 2022
@vgrl
Copy link
Contributor

vgrl commented Mar 2, 2022

👋🏻 @taleleuma—thanks for improving our Docs ✨

sudo command is applicable to Linux only. Doesn't work on windows.

You're correct, and make a good point that we can improve our docs here. Since the advice we're providing (to generally not use sudo or elevated privileges with Git) applies to all operating systems, let's make this clearer in the section title as well as first sentence. I'll commit these changes directly to your branch and then this PR should be good to go! 🎉

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
content/authentication/troubleshooting-ssh/error-permission-denied-publickey.md Modified Original

Copy link
Contributor

@vgrl vgrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vgrl vgrl added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Mar 2, 2022
@vgrl vgrl enabled auto-merge March 2, 2022 02:11
@vgrl vgrl merged commit 99ca7da into github:main Mar 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

authentication Content relating to authentication content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants