Skip to content

Conversation

@uny
Copy link
Contributor

@uny uny commented Mar 22, 2022

Why:

Closes #16443

What's being changed:

It seems that this line was added later.
So I remove this line.

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link

welcome bot commented Mar 22, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 22, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
content/actions/hosting-your-own-runners/about-self-hosted-runners.md Modified Original

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Mar 22, 2022
@ramyaparimi
Copy link
Contributor

@uny
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@pjlogan39

This comment was marked as spam.

@ramyaparimi ramyaparimi added the needs SME This proposal needs review from a subject matter expert label Mar 25, 2022
@martin389 martin389 self-requested a review March 28, 2022 22:41
Copy link
Contributor

@martin389 martin389 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing this! Fix looks good in local staging.

@martin389 martin389 added the ready to merge This pull request is ready to merge label Mar 29, 2022
@martin389 martin389 merged commit 5ea5d23 into github:main Mar 29, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@uny uny deleted the patch-2 branch March 29, 2022 03:42
@arslan-raza-143

This comment was marked as spam.

docs-bot pushed a commit that referenced this pull request Apr 8, 2025
Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team needs SME This proposal needs review from a subject matter expert ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicated lines on about-self-hosted-runners

5 participants