Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Apr 27, 2022

These changes are to include the 'Delete OAuth App' step in 'Migrating OAuth Apps to GitHub Apps'

Why:

Closes [issue link]

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

These changes are to include the 'Delete OAuth App' step in 'Migrating OAuth Apps to GitHub Apps'
@welcome
Copy link

welcome bot commented Apr 27, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 27, 2022
@github-actions
Copy link
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
content/developers/apps/getting-started-with-apps/migrating-oauth-apps-to-github-apps.md Modified Original

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review developers Content related to developers and removed triage Do not begin working on this issue until triaged by the team labels Apr 27, 2022
@ramyaparimi
Copy link
Contributor

@Pawer1234567
Thanks so much for opening a PR! I'll get this triaged for review ⚡

Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this addition! We'll get this merged down for you.

@skedwards88 skedwards88 added the ready to merge This pull request is ready to merge label May 23, 2022
@skedwards88
Copy link
Contributor

@Pawer1234567 you might be interested in this issue, which is related to your changes here: #18052

@janiceilene janiceilene merged commit 50453af into github:main May 24, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team developers Content related to developers ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants