Skip to content

Conversation

@casals
Copy link
Contributor

@casals casals commented Oct 7, 2020

Why:

Fixes #163 .

What's being changed:

In the docs for Creating a default community health file, Step 4 for Creating a repository for default files sounds more suggestive than compulsory, whereas the step is an essential step to setup. I changed the sentence to remove the suggestive tone.

Check off the following:

@janiceilene
Copy link
Contributor

We’re really pleased with how much you’re helping out right away ✨ This is exciting for us because we didn’t expect this kind of response so soon! ⚡

We do need to request that you follow the PR template for all currently outstanding and future PRs though. We don’t feel that it is that much to ask and it really helps us ensure that everyone is giving us the information we need to handle community contributions promptly. 💖

Thanks again for your passion and assistance. You rock! 🙌

@casals
Copy link
Contributor Author

casals commented Oct 7, 2020

We’re really pleased with how much you’re helping out right away ✨ This is exciting for us because we didn’t expect this kind of response so soon! ⚡

We do need to request that you follow the PR template for all currently outstanding and future PRs though. We don’t feel that it is that much to ask and it really helps us ensure that everyone is giving us the information we need to handle community contributions promptly. 💖

Thanks again for your passion and assistance. You rock! 🙌

Oh, I'm terribly sorry - and my apologies in advance for the next PRs going your way. To be honest I didn't realize there was a PR template (since you mentioned it, I went looking and found it at CONTRIBUTING.md - so after that I'm also opening an issue to include this observation/link at README.md :-) )

@janiceilene
Copy link
Contributor

Thanks for updating this one @casals 💝 I'll send it over to @github/docs-content-core for review!

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Oct 7, 2020
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@felicitymay
Copy link
Contributor

Will check back to see when the tests have passed and merge.

@felicitymay felicitymay merged commit b304d28 into github:main Oct 15, 2020
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨

@felicitymay felicitymay added the hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! label Nov 6, 2020
jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
* NFL tutorial draft

* Wording

* Remove redundant paragraph

* Add comments

* Wording

* Add indexes

* Add to query section (github#190)

* Add to query section

* make changes, delete python to put focus on sql

* remove numpy

Co-authored-by: Miranda Auhl <miranda@timescale.com>

* Minor changes

* Varchar --> text

* Small changes from review

Co-authored-by: Lana Brindley <github@lanabrindley.com>

* Small changes part 2

Co-authored-by: Lana Brindley <github@lanabrindley.com>

* Wording

* Add player position and movement visualization

* Take out python prerequisites

* add other queries and fill analytics section (github#193)

* add other queries and fill analytics section

* updates

* one last change

* one last change to help merge

Co-authored-by: Miranda Auhl <miranda@timescale.com>

* add imag urls

* Additional info about tables, fields

* Add download links for datasets

* update images to correct folder location

* Add play drawing code and images

* Fix image links

* Add create_hypertable

* Formatting and links

* reorganization of the NFL tutorial, breaking it up into multiple pages. (github#202)

* reorganization of the NFL tutorial, breaking it up into multiple pages.

* Fixing links on first page

* Updating both index pages with links and text

* Apply suggestions from code review

Lots of good cleanup thanks to Miranda and Lana!

Co-authored-by: Lana Brindley <github@lanabrindley.com>
Co-authored-by: mirandaauhl <82287545+mirandaauhl@users.noreply.github.com>

* Remove "TimescaleDB Toolkit" in place of hyperfunction

* Made the tutorial more generic about time-series data

* cleaned up section names in left nav

* Added a little more exposition

* Apply suggestions from code review

add query info in relational page

* Add queries to relational page

* Apply suggestions from code review

add comma to fix query

* fix one part of the queries

* Apply suggestions from code review

apply cagg comments

* Apply suggestions from code review

update titles

* add tables and some exposition

Co-authored-by: Ryan Booz <ryan@timescale.com>
Co-authored-by: mirandaauhl <82287545+mirandaauhl@users.noreply.github.com>
Co-authored-by: Miranda Auhl <miranda@timescale.com>
Co-authored-by: Lana Brindley <github@lanabrindley.com>
Co-authored-by: Prashant Sridharan <prashant_sridharan@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[From Zendesk] Improve Docs for Creating a default community health file

3 participants