-
Notifications
You must be signed in to change notification settings - Fork 65.6k
Update creating-a-default-community-health-file.md #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We’re really pleased with how much you’re helping out right away ✨ This is exciting for us because we didn’t expect this kind of response so soon! ⚡ We do need to request that you follow the PR template for all currently outstanding and future PRs though. We don’t feel that it is that much to ask and it really helps us ensure that everyone is giving us the information we need to handle community contributions promptly. 💖 Thanks again for your passion and assistance. You rock! 🙌 |
Oh, I'm terribly sorry - and my apologies in advance for the next PRs going your way. To be honest I didn't realize there was a PR template (since you mentioned it, I went looking and found it at |
|
Thanks for updating this one @casals 💝 I'll send it over to @github/docs-content-core for review! |
content/github/building-a-strong-community/creating-a-default-community-health-file.md
Outdated
Show resolved
Hide resolved
Updated with requested changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
|
Will check back to see when the tests have passed and merge. |
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨ |
* NFL tutorial draft * Wording * Remove redundant paragraph * Add comments * Wording * Add indexes * Add to query section (github#190) * Add to query section * make changes, delete python to put focus on sql * remove numpy Co-authored-by: Miranda Auhl <miranda@timescale.com> * Minor changes * Varchar --> text * Small changes from review Co-authored-by: Lana Brindley <github@lanabrindley.com> * Small changes part 2 Co-authored-by: Lana Brindley <github@lanabrindley.com> * Wording * Add player position and movement visualization * Take out python prerequisites * add other queries and fill analytics section (github#193) * add other queries and fill analytics section * updates * one last change * one last change to help merge Co-authored-by: Miranda Auhl <miranda@timescale.com> * add imag urls * Additional info about tables, fields * Add download links for datasets * update images to correct folder location * Add play drawing code and images * Fix image links * Add create_hypertable * Formatting and links * reorganization of the NFL tutorial, breaking it up into multiple pages. (github#202) * reorganization of the NFL tutorial, breaking it up into multiple pages. * Fixing links on first page * Updating both index pages with links and text * Apply suggestions from code review Lots of good cleanup thanks to Miranda and Lana! Co-authored-by: Lana Brindley <github@lanabrindley.com> Co-authored-by: mirandaauhl <82287545+mirandaauhl@users.noreply.github.com> * Remove "TimescaleDB Toolkit" in place of hyperfunction * Made the tutorial more generic about time-series data * cleaned up section names in left nav * Added a little more exposition * Apply suggestions from code review add query info in relational page * Add queries to relational page * Apply suggestions from code review add comma to fix query * fix one part of the queries * Apply suggestions from code review apply cagg comments * Apply suggestions from code review update titles * add tables and some exposition Co-authored-by: Ryan Booz <ryan@timescale.com> Co-authored-by: mirandaauhl <82287545+mirandaauhl@users.noreply.github.com> Co-authored-by: Miranda Auhl <miranda@timescale.com> Co-authored-by: Lana Brindley <github@lanabrindley.com> Co-authored-by: Prashant Sridharan <prashant_sridharan@hotmail.com>
Why:
Fixes #163 .
What's being changed:
In the docs for
Creating a default community health file, Step 4 forCreating a repository for default filessounds more suggestive than compulsory, whereas the step is an essential step to setup. I changed the sentence to remove the suggestive tone.Check off the following: