Skip to content

Conversation

@joshjohanning
Copy link
Contributor

@joshjohanning joshjohanning commented Aug 19, 2022

Why:

The default shell for container jobs is sh vs. bash. This can cause run scripts to fail if using bashisms (for example, if statements with double brackets).

Calling this out in the reusable for a job container.

Reference:
actions/runner#1533 (comment), which references: actions/runner#353 (comment)

What's being changed (if available, include any code snippets, screenshots, or gifs):

Adding the content in the blue note:
image

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 19, 2022
@cmwilson21
Copy link
Contributor

👋 @joshjohanning Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Aug 22, 2022
Copy link
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this, @joshjohanning! I'll get it merged.

@lucascosti lucascosti enabled auto-merge August 31, 2022 07:04
@lucascosti lucascosti merged commit 1d4406c into github:main Aug 31, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@joshjohanning joshjohanning deleted the patch-5 branch August 31, 2022 15:23
@joshjohanning joshjohanning restored the patch-5 branch August 31, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants