Skip to content

Conversation

@shuklaayush
Copy link
Contributor

@shuklaayush shuklaayush commented Aug 25, 2022

The config command expects a path to the private/public key and needs to be prefixed with key:: when using the public key directly
ref: https://git-scm.com/docs/git-config#Documentation/git-config.txt-usersigningKey

Why:

Closes 20114

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

The config command expects a path to the private/public key and needs to be prefixed with `key::` when using the public key directly 
ref: https://git-scm.com/docs/git-config#Documentation/git-config.txt-usersigningKey
@welcome
Copy link

welcome bot commented Aug 25, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 25, 2022
@cmwilson21
Copy link
Contributor

@shuklaayush thanks for opening a PR! It looks like someone opened an issue about this yesterday, so I'm going to edit your post to link the two of them together.

I'll get this triaged for review! ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review ssh Content related to SSH authentication Content relating to authentication and removed triage Do not begin working on this issue until triaged by the team labels Aug 26, 2022
@0649044724

This comment was marked as spam.

Copy link

@robookwus robookwus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey I'd like to help with the docs

Copy link
Contributor

@rachaelrenk rachaelrenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! ✨ Thank you for making this update.

@rachaelrenk rachaelrenk merged commit 2a97aa6 into github:main Oct 11, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@shuklaayush shuklaayush deleted the patch-2 branch October 11, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

authentication Content relating to authentication content This issue or pull request belongs to the Docs Content team ssh Content related to SSH waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SSH commit signing: Missing "key::" prefix for literal key in setup instructions

5 participants