Skip to content

Fix misleading example of reusable workflows #20324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucascosti merged 5 commits into from
Sep 1, 2022
+3 −2
Merged

Fix misleading example of reusable workflows #20324

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b38c393
Revert "Use valid reusable workflow paths in example yml"
joshjohanning Aug 31, 2022
8355fe8
adding note about using a local action
joshjohanning Aug 31, 2022
a41a24f
removing the local action reference entirely
joshjohanning Aug 31, 2022
12ca61d
Apply suggestions from code review
lucascosti Sep 1, 2022
ba5b76a
Merge branch 'main' into patch-6
lucascosti Sep 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions content/actions/using-workflows/reusing-workflows.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ You can define inputs and secrets, which can be passed from the caller workflow
runs-on: ubuntu-latest
environment: production
steps:
- uses: ./.github/workflows/my-action
- uses: octo-org/my-action@v1
with:
username: ${{ inputs.username }}
token: ${{ secrets.envPAT }}
Expand Down Expand Up @@ -168,12 +168,13 @@ jobs:
name: Pass input and secrets to my-action
runs-on: ubuntu-latest
steps:
- uses: ./.github/workflows/my-action
- uses: octo-org/my-action@v1
with:
username: ${{ inputs.username }}
token: ${{ secrets.token }}
```
{% endraw %}

{% ifversion actions-reusable-workflow-matrix %}
## Using a matrix strategy with a reusable workflow

Expand Down