Skip to content

Conversation

@schalkneethling
Copy link

Ensure the consistent use of canceled in prose.

Note: Seems like Prettier made some formatting changes to the Markdown files. I hope that is OK.

fix #22624

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Ensure the consistent use of canceled in prose.

fix github#22624
@schalkneethling schalkneethling requested a review from a team as a code owner January 6, 2023 16:34
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jan 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
.devcontainer/**
.github/actions-scripts/**
.github/workflows/**
.github/CODEOWNERS
assets/fonts/**
data/graphql/**
Dockerfile*
lib/graphql/**
lib/redirects/**
lib/rest/**
lib/webhooks/**
package*.json
scripts/**
content/actions/deployment/security-hardening-your-deployments/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
.devcontainer/**
.github/actions-scripts/**
.github/workflows/**
.github/CODEOWNERS
assets/fonts/**
data/graphql/**
Dockerfile*
lib/graphql/**
lib/redirects/**
lib/rest/**
lib/webhooks/**
package*.json
scripts/**
content/actions/deployment/security-hardening-your-deployments/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
codespaces/troubleshooting/troubleshooting-creation-and-deletion-of-codespaces.md fpt
ghec
fpt
ghec
communities/maintaining-your-safety-on-github/blocking-a-user-from-your-organization.md fpt
ghec
fpt
ghec
communities/maintaining-your-safety-on-github/blocking-a-user-from-your-personal-account.md fpt
ghec
fpt
ghec
developers/github-marketplace/creating-apps-for-github-marketplace/viewing-metrics-for-your-listing.md fpt
ghec
fpt
ghec
developers/github-marketplace/creating-apps-for-github-marketplace/viewing-transactions-for-your-listing.md fpt
ghec
fpt
ghec
developers/github-marketplace/selling-your-app-on-github-marketplace/pricing-plans-for-github-marketplace-apps.md fpt
ghec
fpt
ghec
developers/github-marketplace/using-the-github-marketplace-api-in-your-app/handling-plan-cancellations.md fpt
ghec
fpt
ghec
organizations/managing-membership-in-your-organization/removing-a-member-from-your-organization.md fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae
fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae
site-policy/github-terms/github-corporate-terms-of-service.md fpt
fpt
site-policy/github-terms/github-terms-of-service.md fpt
fpt
sponsors/receiving-sponsorships-through-github-sponsors/managing-your-sponsorship-tiers.md fpt
ghec
fpt
ghec

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@schalkneethling schalkneethling force-pushed the consistency-of-canceled-in-prose branch from aa1bd8e to 9690e9e Compare January 6, 2023 16:43
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
.devcontainer/**
.github/actions-scripts/**
.github/workflows/**
.github/CODEOWNERS
assets/fonts/**
data/graphql/**
Dockerfile*
lib/graphql/**
lib/redirects/**
lib/rest/**
lib/webhooks/**
package*.json
scripts/**
content/actions/deployment/security-hardening-your-deployments/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

@schalkneethling
Copy link
Author

Simplified Chinese is failing because: Error: Input required and not supplied: token - Node.js Tests / test (translations) (pull_request)

@cmwilson21
Copy link
Contributor

👋 Hello @schalkneethling! Thanks for the PR!

However, we did get a PR with this fix a couple weeks ago during our repo freeze. After waiting for the thaw, we had to get site-policy to approve, which they did right before the weekend. Since their approval, we are working on getting that PR merged down.

Since this is considered a duplicate right now, I'm going to go ahead and close it. If something happens to the other PR and we are unable to accept it, I'll reopen yours. I apologize for the inconvenience and will look into how we can prevent similar situations in the future. 💖

As always, we appreciate your interest in and passion for improving the Docs! ✨

@cmwilson21 cmwilson21 closed this Jan 9, 2023
@cmwilson21 cmwilson21 removed the request for review from a team January 9, 2023 21:56
@cmwilson21 cmwilson21 removed the triage Do not begin working on this issue until triaged by the team label Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement]: Consistency for spelling of "canceled" in non-API docs

2 participants