Skip to content

Conversation

@d-c-d
Copy link
Contributor

@d-c-d d-c-d commented Oct 8, 2020

new work processes use 'main' instead of 'master'

Why:

What's being changed:

Check off the following:

new work processes use 'main' instead of 'master'
@welcome
Copy link

welcome bot commented Oct 8, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

$ git checkout master
> Switched to branch 'master'
$ git checkout main
> Switched to branch 'https://github.com/todbot/qtpy-tricks.git'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switched to branch 'main'

@janiceilene
Copy link
Contributor

janiceilene commented Oct 8, 2020

Before we review this, please fill out the PR template.

👋 Thanks for the PR @d-c-d! I'll let the @github/docs-content-core team know this is ready for review 🌟

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Oct 8, 2020
Copy link
Contributor

@megbird megbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you for these changes! I had one suggestion to make this work more maintainable for a wider audience. You can commit the suggestion and we'll merge it in 😄

Copy link
Contributor

@infin8x infin8x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes! I think they're good to merge. @megbird (or other GitHub docs folks) - I wonder if a reusable on this (and other) pages would be helpful, something like:

"Many repositories have renamed their default branch from master to main, so we've updated these instructions accordingly. If the repository you're using still uses master as the default branch, replace main with master in these instructions."

@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Oct 23, 2020
…cing-a-fork.md

Co-authored-by: Alex Mullans <infin8x@github.com>
@janiceilene
Copy link
Contributor

There was one pending suggestion, so I committed it. I'll get this branch updated and merge it in once tests are green 🍏 Thanks so much @d-c-d 💝

@janiceilene janiceilene merged commit 269114b into github:main Oct 23, 2020
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team stale There is no recent activity on this issue or pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants