Conversation
|
Hi @sabrowning1! Started working on the conceptual article! Made a draft PR to signify it is still a wip. Please check this out when you are chanced! |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request. fpt: Free, Pro, Team |
sabrowning1
left a comment
There was a problem hiding this comment.
Thanks for starting on this! 😁 These suggestions should fix the frontmatter 👍🏼
...coursework-with-github-classroom/get-started-with-github-classroom/about-github-classroom.md
Outdated
Show resolved
Hide resolved
...coursework-with-github-classroom/get-started-with-github-classroom/about-github-classroom.md
Outdated
Show resolved
Hide resolved
...coursework-with-github-classroom/get-started-with-github-classroom/about-github-classroom.md
Outdated
Show resolved
Hide resolved
…started-with-github-classroom/about-github-classroom.md Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
sabrowning1
left a comment
There was a problem hiding this comment.
Thanks so much for working on this @OlayinkaAtobiloye! 😁 This is looking great, I've left some initial feedback 👍🏼
...coursework-with-github-classroom/get-started-with-github-classroom/about-github-classroom.md
Show resolved
Hide resolved
...coursework-with-github-classroom/get-started-with-github-classroom/about-github-classroom.md
Show resolved
Hide resolved
...coursework-with-github-classroom/get-started-with-github-classroom/about-github-classroom.md
Outdated
Show resolved
Hide resolved
...coursework-with-github-classroom/get-started-with-github-classroom/about-github-classroom.md
Outdated
Show resolved
Hide resolved
...coursework-with-github-classroom/get-started-with-github-classroom/about-github-classroom.md
Outdated
Show resolved
Hide resolved
...coursework-with-github-classroom/get-started-with-github-classroom/about-github-classroom.md
Outdated
Show resolved
Hide resolved
...coursework-with-github-classroom/get-started-with-github-classroom/about-github-classroom.md
Outdated
Show resolved
Hide resolved
...coursework-with-github-classroom/get-started-with-github-classroom/about-github-classroom.md
Show resolved
Hide resolved
...coursework-with-github-classroom/get-started-with-github-classroom/about-github-classroom.md
Outdated
Show resolved
Hide resolved
...coursework-with-github-classroom/get-started-with-github-classroom/about-github-classroom.md
Outdated
Show resolved
Hide resolved
…started-with-github-classroom/about-github-classroom.md Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
sabrowning1
left a comment
There was a problem hiding this comment.
Thanks for working through that first round of feedback @OlayinkaAtobiloye, this is really taking shape! 💖 I've left some comments below focused mainly on word choice, clarity, and concision. The only other suggestion I have now is to order the features alphabetically—since this is almost an unordered list, I'd say we should go with the style guide. Alphabetizing the features should make it easier for users looking for specific features to skim that section 🙂
Thanks again for your hard work on this! As usual, feel free to ping me with any questions 😁
...coursework-with-github-classroom/get-started-with-github-classroom/about-github-classroom.md
Outdated
Show resolved
Hide resolved
...coursework-with-github-classroom/get-started-with-github-classroom/about-github-classroom.md
Outdated
Show resolved
Hide resolved
...coursework-with-github-classroom/get-started-with-github-classroom/about-github-classroom.md
Outdated
Show resolved
Hide resolved
...coursework-with-github-classroom/get-started-with-github-classroom/about-github-classroom.md
Outdated
Show resolved
Hide resolved
...coursework-with-github-classroom/get-started-with-github-classroom/about-github-classroom.md
Outdated
Show resolved
Hide resolved
...coursework-with-github-classroom/get-started-with-github-classroom/about-github-classroom.md
Outdated
Show resolved
Hide resolved
...coursework-with-github-classroom/get-started-with-github-classroom/about-github-classroom.md
Outdated
Show resolved
Hide resolved
...coursework-with-github-classroom/get-started-with-github-classroom/about-github-classroom.md
Outdated
Show resolved
Hide resolved
...coursework-with-github-classroom/get-started-with-github-classroom/about-github-classroom.md
Outdated
Show resolved
Hide resolved
...coursework-with-github-classroom/get-started-with-github-classroom/about-github-classroom.md
Outdated
Show resolved
Hide resolved
…started-with-github-classroom/about-github-classroom.md Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
...education/manage-coursework-with-github-classroom/get-started-with-github-classroom/index.md
Outdated
Show resolved
Hide resolved
...education/manage-coursework-with-github-classroom/get-started-with-github-classroom/index.md
Outdated
Show resolved
Hide resolved
…started-with-github-classroom/index.md Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
…started-with-github-classroom/index.md Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
There was a problem hiding this comment.
@OlayinkaAtobiloye 👋🏻 - great work 💖
I added a few comments and made a few suggestions. Feel free to ignore those you don't agree with, as some may be due to personal preference.
The two main points I'd like you to take a look at are:
- the links to the articles in the "Further reading" section of the new article.
- whether you should (or want to) add links to the new article from existing GitHub Classroom articles
Hope this review helps ✨
...coursework-with-github-classroom/get-started-with-github-classroom/about-github-classroom.md
Outdated
Show resolved
Hide resolved
...coursework-with-github-classroom/get-started-with-github-classroom/about-github-classroom.md
Outdated
Show resolved
Hide resolved
...coursework-with-github-classroom/get-started-with-github-classroom/about-github-classroom.md
Outdated
Show resolved
Hide resolved
...coursework-with-github-classroom/get-started-with-github-classroom/about-github-classroom.md
Outdated
Show resolved
Hide resolved
...coursework-with-github-classroom/get-started-with-github-classroom/about-github-classroom.md
Outdated
Show resolved
Hide resolved
...coursework-with-github-classroom/get-started-with-github-classroom/about-github-classroom.md
Show resolved
Hide resolved
...ge-coursework-with-github-classroom/teach-with-github-classroom/create-a-group-assignment.md
Show resolved
Hide resolved
...coursework-with-github-classroom/get-started-with-github-classroom/about-github-classroom.md
Outdated
Show resolved
Hide resolved
...coursework-with-github-classroom/get-started-with-github-classroom/about-github-classroom.md
Outdated
Show resolved
Hide resolved
…started-with-github-classroom/about-github-classroom.md Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com>
Hi @mchammer01, thanks for the review - super helpful!❤️ Made some changes, please confirm if this is good to go when you are chanced.✨ |
|
@OlayinkaAtobiloye - thanks for addressing my comments ✨ |
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Closes ISSUE
What's being changed (if available, include any code snippets, screenshots, or gifs):
Check off the following: