-
Notifications
You must be signed in to change notification settings - Fork 66k
Add guide for setting up php codespaces #25720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request. fpt: Free, Pro, Team |
would be nice if it were documented somewhere
|
Hmm, none of my changes are visible on the preview links. What have I missed? |
|
@garrettw Thanks for opening an issue and linking it to your PR! ⚡ We appreciate your time with this. I'll get it triaged for review ✨ However, I'm unsure about the error in the preview. We'll look into that a bit more and hopefully find an answer for you 💖 |
|
@garrettw - Many thanks for raising this PR. The preview for this wasn't working because the new article needed to be added to the index.md file for https://docs-25720-f52a5e.preview.ghdocs.com/codespaces/setting-up-your-project-for-codespaces/adding-a-dev-container-configuration. I've added this now. I'll take a look at this PR and check with product management about adding the new article. Thanks again for your work on this. 👍 |
hubwriter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added some suggestions of changes to make this match what I get in the devcontainer.json when I step through this article (using the preview).
Unfortunately, when I get the the end and run the application I get an error. This needs some debugging.
...odespaces/adding-a-dev-container-configuration/setting-up-your-php-project-for-codespaces.md
Outdated
Show resolved
Hide resolved
...odespaces/adding-a-dev-container-configuration/setting-up-your-php-project-for-codespaces.md
Outdated
Show resolved
Hide resolved
...odespaces/adding-a-dev-container-configuration/setting-up-your-php-project-for-codespaces.md
Show resolved
Hide resolved
...odespaces/adding-a-dev-container-configuration/setting-up-your-php-project-for-codespaces.md
Outdated
Show resolved
Hide resolved
...odespaces/adding-a-dev-container-configuration/setting-up-your-php-project-for-codespaces.md
Outdated
Show resolved
Hide resolved
...odespaces/adding-a-dev-container-configuration/setting-up-your-php-project-for-codespaces.md
Outdated
Show resolved
Hide resolved
...odespaces/adding-a-dev-container-configuration/setting-up-your-php-project-for-codespaces.md
Show resolved
Hide resolved
|
@garrettw - please move this PR out of the Draft state when it's ready for a re-review. Thanks. |
|
👋 Hey @garrettw - just wanted to check in and see if this is ready for re-review? No rush, just didn't want it to fall off the radar 👍 |
This comment was marked as spam.
This comment was marked as spam.
|
Not sure why it refuses to deploy when I push a commit. I guess someone else will have to do it again. |
...odespaces/adding-a-dev-container-configuration/setting-up-your-php-project-for-codespaces.md
Outdated
Show resolved
Hide resolved
...odespaces/adding-a-dev-container-configuration/setting-up-your-php-project-for-codespaces.md
Outdated
Show resolved
Hide resolved
...odespaces/adding-a-dev-container-configuration/setting-up-your-php-project-for-codespaces.md
Outdated
Show resolved
Hide resolved
...odespaces/adding-a-dev-container-configuration/setting-up-your-php-project-for-codespaces.md
Outdated
Show resolved
Hide resolved
hubwriter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@garrettw - Many thanks for the changes you've made.
Unfortunately, when I step through the revised article (https://docs-25720-f52a5e.preview.ghdocs.com/en/codespaces/setting-up-your-project-for-codespaces/adding-a-dev-container-configuration/setting-up-your-php-project-for-codespaces) the end result is a 403 "Forbidden" page.
We need to make this tutorial bullet-proof for folks, so that it will work for everyone who tries it. If you can fix this that'd be great. Thanks again for your work on this. 👍
...odespaces/adding-a-dev-container-configuration/setting-up-your-php-project-for-codespaces.md
Outdated
Show resolved
Hide resolved
...odespaces/adding-a-dev-container-configuration/setting-up-your-php-project-for-codespaces.md
Outdated
Show resolved
Hide resolved
...odespaces/adding-a-dev-container-configuration/setting-up-your-php-project-for-codespaces.md
Show resolved
Hide resolved
...odespaces/adding-a-dev-container-configuration/setting-up-your-php-project-for-codespaces.md
Show resolved
Hide resolved
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Co-authored-by: hubwriter <hubwriter@github.com>
Co-authored-by: hubwriter <hubwriter@github.com>
...odespaces/adding-a-dev-container-configuration/setting-up-your-php-project-for-codespaces.md
Outdated
Show resolved
Hide resolved
...odespaces/adding-a-dev-container-configuration/setting-up-your-php-project-for-codespaces.md
Outdated
Show resolved
Hide resolved
...odespaces/adding-a-dev-container-configuration/setting-up-your-php-project-for-codespaces.md
Outdated
Show resolved
Hide resolved
hubwriter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@garrettw - This is great! Many thanks for your work on this. I've tested the article in the preview and it's working just fine now. Thanks for sticking with this. It's really nice to have a PHP tutorial to add to the others. 🎉
I'll get this merged and published now.
Many thanks again. 🎖️
🚀
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
There is already a PHP template for Codespaces, but no guide to match.
Closes: #25719
What's being changed (if available, include any code snippets, screenshots, or gifs):
added an article, though I'll need help or guidance on getting the necessary screenshots added in
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.
datadirectory.For content changes, I have completed the self-review checklist.