Skip to content

Conversation

@garrettw
Copy link
Contributor

@garrettw garrettw commented May 26, 2023

Why:

There is already a PHP template for Codespaces, but no guide to match.

Closes: #25719

What's being changed (if available, include any code snippets, screenshots, or gifs):

added an article, though I'll need help or guidance on getting the necessary screenshots added in

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@welcome
Copy link

welcome bot commented May 26, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label May 26, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 26, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
codespaces/guides.md fpt
ghec
fpt
ghec
codespaces/index.md fpt
ghec
fpt
ghec
codespaces/setting-up-your-project-for-codespaces/adding-a-dev-container-configuration/index.md fpt
ghec
fpt
ghec
New file: codespaces/setting-up-your-project-for-codespaces/adding-a-dev-container-configuration/setting-up-your-php-project-for-codespaces.md fpt
ghec
fpt
ghec

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

would be nice if it were documented somewhere
@garrettw
Copy link
Contributor Author

garrettw commented May 27, 2023

Hmm, none of my changes are visible on the preview links. What have I missed?

@cmwilson21
Copy link
Contributor

@garrettw Thanks for opening an issue and linking it to your PR! ⚡

We appreciate your time with this. I'll get it triaged for review ✨

However, I'm unsure about the error in the preview. We'll look into that a bit more and hopefully find an answer for you 💖

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review Codespaces Content relating to GitHub Codespaces and removed triage Do not begin working on this issue until triaged by the team labels May 31, 2023
@hubwriter
Copy link
Contributor

@garrettw - Many thanks for raising this PR.

The preview for this wasn't working because the new article needed to be added to the index.md file for https://docs-25720-f52a5e.preview.ghdocs.com/codespaces/setting-up-your-project-for-codespaces/adding-a-dev-container-configuration. I've added this now.

I'll take a look at this PR and check with product management about adding the new article. Thanks again for your work on this. 👍

Copy link
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some suggestions of changes to make this match what I get in the devcontainer.json when I step through this article (using the preview).

Unfortunately, when I get the the end and run the application I get an error. This needs some debugging.

@hubwriter
Copy link
Contributor

@garrettw - please move this PR out of the Draft state when it's ready for a re-review. Thanks.

@cmwilson21
Copy link
Contributor

👋 Hey @garrettw - just wanted to check in and see if this is ready for re-review? No rush, just didn't want it to fall off the radar 👍

afeeq19

This comment was marked as spam.

@mohmadalabdalui

This comment was marked as spam.

@garrettw garrettw marked this pull request as ready for review July 22, 2023 04:53
@garrettw
Copy link
Contributor Author

Not sure why it refuses to deploy when I push a commit. I guess someone else will have to do it again.

Copy link
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garrettw - Many thanks for the changes you've made.

Unfortunately, when I step through the revised article (https://docs-25720-f52a5e.preview.ghdocs.com/en/codespaces/setting-up-your-project-for-codespaces/adding-a-dev-container-configuration/setting-up-your-php-project-for-codespaces) the end result is a 403 "Forbidden" page.

We need to make this tutorial bullet-proof for folks, so that it will work for everyone who tries it. If you can fix this that'd be great. Thanks again for your work on this. 👍

@Jhoine

This comment was marked as spam.

@Jhoine

This comment was marked as spam.

@Jhoine

This comment was marked as spam.

garrettw and others added 3 commits July 24, 2023 13:09
Co-authored-by: hubwriter <hubwriter@github.com>
Co-authored-by: hubwriter <hubwriter@github.com>
@garrettw garrettw requested a review from hubwriter July 31, 2023 21:11
Copy link
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garrettw - This is great! Many thanks for your work on this. I've tested the article in the preview and it's working just fine now. Thanks for sticking with this. It's really nice to have a PHP tutorial to add to the others. 🎉

I'll get this merged and published now.

Many thanks again. 🎖️
🚀

@hubwriter hubwriter enabled auto-merge August 2, 2023 10:45
@hubwriter hubwriter added this pull request to the merge queue Aug 2, 2023
Merged via the queue into github:main with commit 8ad6241 Aug 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Codespaces Content relating to GitHub Codespaces content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PHP Codespaces template exists, but there is no setup guide for it in the docs

6 participants