Skip to content

Conversation

@raffis
Copy link
Contributor

@raffis raffis commented Sep 1, 2023

Why:

Current arc docs lists two metrics which are not exposed.
In the pr which added these metrics available_jobs and acquired_jobs are actually commented:
actions/actions-runner-controller@a0a3916#diff-45afc66b23a4ce69ef91a1ee70fd48b378fa89ad649c7c2275ccff5516f9e497R54-R70

What's being changed (if available, include any code snippets, screenshots, or gifs):

Remove metrics from the docs (until the metrics are actually exposed by the controller),

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

Signed-off-by: Raffael Sahli <raffael.sahli@doodle.com>
@welcome
Copy link

welcome bot commented Sep 1, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/hosting-your-own-runners/managing-self-hosted-runners-with-actions-runner-controller/deploying-runner-scale-sets-with-actions-runner-controller.md fpt
ghec
ghes@ 3.10 3.9
fpt
ghec
ghes@ 3.10 3.9

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

@raffis Thanks so much for submitting a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Sep 1, 2023
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for linking to the PR that introduces these two new metrics and highlighting the fact that they have not shipped yet. ✨

Looking at master I can see that they are still commented out.

Thank you for letting us know about this error and for fixing it 🚀

@felicitymay felicitymay added this pull request to the merge queue Sep 5, 2023
Merged via the queue into github:main with commit f2d3077 Sep 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants