-
Notifications
You must be signed in to change notification settings - Fork 65.3k
Fix indentation of groups yaml example #28056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@DenverCoder1 Thanks so much for submitting a PR! I'll get this triaged for review ⚡ |
jurre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that's totally right! 🙇
am-stead
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @DenverCoder1 for creating this PR and fixing this mistake! 🙏
I'll get this merged. ✨
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
When I saw this example, I assumed this meant you could have
groupsdefined outside ofupdatesto apply to all package types. Doing so, however, causes the dependabot file check to fail with the following error:Closes #27987
What's being changed (if available, include any code snippets, screenshots, or gifs):
This example shows
groupsat the top level of a dependabot.yml. This PR corrects it to have the groups indented within the npm updates settings since it otherwise fails.Relevent docs links:
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.
datadirectory.For content changes, I have completed the self-review checklist.