Skip to content

Conversation

@shades-7
Copy link
Contributor

@shades-7 shades-7 commented Feb 18, 2021

Why:

Closes #523

What's being changed:

Changed the content of the note and its position (https://docs.github.com/en/github/managing-your-work-on-github/linking-a-repository-to-a-project-board)
Screenshot from 2021-02-19 01-00-28

Check off the following:

@welcome
Copy link

welcome bot commented Feb 18, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

Thanks so much for opening a PR with this fix @shades-7! I edited your original comment to read Closes https://github.com/github/docs/issues/523. When you write it that way, it automatically links the pull request to the issue (you can see it in the sidebar now!) and the issue will close once the PR is merged 🎉

I'll get this triaged for review 💖

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core waiting for review Issue/PR is waiting for a writer's review labels Feb 18, 2021
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋🏻 Hi @shades-7

Thanks for your PR. It was really thoughtful of you to include a screenshot so that I could see how your changes looked (and good to see that you have managed to get the docs system working locally) ✨

For future reference, when you raise a PR, we automatically create a temporary server with your changes, as part of the testing. On the repository "Conversation" tab, there's a section called "This branch was successfully deployed" which contains a View deployment button to the staging environment. You can see your changes here: https://docs-3774--shades-7docs.herokuapp.com/en/github/managing-your-work-on-github/linking-a-repository-to-a-project-board.

I've added a comment with a change, but otherwise this looks good to merge.

@felicitymay felicitymay removed the waiting for review Issue/PR is waiting for a writer's review label Feb 22, 2021
@Alyana38

This comment has been minimized.

@felicitymay felicitymay enabled auto-merge (squash) February 24, 2021 09:52
@felicitymay felicitymay merged commit cca5ed5 into github:main Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please add how to link forked repo to a project board

5 participants