Skip to content

Conversation

@bdresser
Copy link
Contributor

Why:

Documentation is out of date! Discussion activity shows up on the contribution graph.

What's being changed:

adds "opened a discussion; answered a discussion" to list of activities that show in contribution graph.

Check off the following:

@welcome
Copy link

welcome bot commented Mar 18, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 18, 2021
@bdresser bdresser requested review from cheshire137 and evi-liu March 18, 2021 21:05
@evi-liu
Copy link
Contributor

evi-liu commented Mar 18, 2021

thank you for opening this PR! 🙌

Copy link
Contributor

@janiceilene janiceilene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for opening a PR @bdresser! This change looks 💯 I'll update the branch and get this merged 🚀

Edit: I just saw @cheshire137 is requested for review, so I'll hold off until that's done 👍

Copy link
Member

@cheshire137 cheshire137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is accurate!

@janiceilene
Copy link
Contributor

Thanks folks! I'll update the branch and get this merged in soon ⚡

@janiceilene janiceilene added the ready to merge This pull request is ready to merge label Mar 19, 2021
@janiceilene janiceilene merged commit 4327912 into main Mar 19, 2021
@janiceilene janiceilene deleted the bmd/add-discussions branch March 19, 2021 20:06
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge This pull request is ready to merge triage Do not begin working on this issue until triaged by the team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants