-
Notifications
You must be signed in to change notification settings - Fork 65.5k
Fix typos #7451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos #7451
Conversation
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
.github/actions-scripts/**
.github/workflows/**
.github/CODEOWNERS
assets/fonts/**
data/graphql/**
lib/graphql/**
lib/redirects/**
lib/rest/**
lib/webhooks/**
scripts/**
translations/**
You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. ![]()
|
Hehe, a bit strange to see a bot requesting changes, but I concede. I'll try to fix those. |
|
So it looks like |
|
ping @heiskr @skedwards88 @janiceilene? What should I do about this? |
|
@bl-ue Please refrain from pinging individuals who are not involved in the PR or issue you're working in. Thanks for opening a PR with these fixes! I believe the only official problem was the |
I'm sorry @janiceilene — I just wanted to make sure that I wasn't being ignored because you saw that changes were requested. I'll keep that in mind.
Ah, great point.
Thank you! :) |
|
👋 @bl-ue Can you remove the translated files from this PR? Let me know when that's done and I'll get this up for review. |
|
Done @janiceilene. I saved the old branch locally in case we need it. |
mchammer01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing these typos 😉
Taken care of by PR author
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Fixed typos found with codespell & cSpell.
What's being changed:
Check off the following:
A few notes here.
Some of the file names had typos in, so I renamed them and updated all references to them that I could fine (edace80 & 4d699c3). I'll check on the staging site to see if they're ok
For consistency, I updated some of the legal docs (agreements, data protection, etc.) to use American English all over, because for
authorizedandorganizationalthey were using mixedYour contributing guidelines say not to contribute translations here which I totally understand, but I was wondering if I could submit these translation changes that I did since they're identical across all translations, and I'd almost classify them as syntactical rather than normal translations.
I changed
reenabletore-enableA few trailing newlines were trimmed at the ends of some files