Skip to content

Conversation

@bl-ue
Copy link
Contributor

@bl-ue bl-ue commented Jun 16, 2021

Why:

Fixed typos found with codespell & cSpell.

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for the deploy-to-heroku link in your pull request, then click View deployment).
  • For content changes, I have completed the self-review checklist.

A few notes here.

  • Some of the file names had typos in, so I renamed them and updated all references to them that I could fine (edace80 & 4d699c3). I'll check on the staging site to see if they're ok

  • For consistency, I updated some of the legal docs (agreements, data protection, etc.) to use American English all over, because for authorized and organizational they were using mixed

  • Your contributing guidelines say not to contribute translations here which I totally understand, but I was wondering if I could submit these translation changes that I did since they're identical across all translations, and I'd almost classify them as syntactical rather than normal translations.

  • I changed reenable to re-enable

  • A few trailing newlines were trimmed at the ends of some files

@bl-ue bl-ue requested review from a team as code owners June 16, 2021 22:14
@welcome
Copy link

welcome bot commented Jun 16, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jun 16, 2021
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
.github/actions-scripts/**
.github/workflows/**
.github/CODEOWNERS
assets/fonts/**
data/graphql/**
lib/graphql/**
lib/redirects/**
lib/rest/**
lib/webhooks/**
scripts/**
translations/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

@bl-ue
Copy link
Contributor Author

bl-ue commented Jun 16, 2021

Hehe, a bit strange to see a bot requesting changes, but I concede. I'll try to fix those.

@bl-ue
Copy link
Contributor Author

bl-ue commented Jun 16, 2021

So it looks like translations/** is the only bad guy 😞. Just to confirm (@janiceilene, ...?), I should definitely undo those changes? They're just references to files in ![]() images.

@heiskr heiskr removed the request for review from a team June 17, 2021 15:09
@bl-ue
Copy link
Contributor Author

bl-ue commented Jun 18, 2021

ping @heiskr @skedwards88 @janiceilene? What should I do about this?

@github github deleted a comment Jun 18, 2021
@github github deleted a comment Jun 18, 2021
@github github deleted a comment Jun 18, 2021
@github github deleted a comment Jun 18, 2021
@janiceilene
Copy link
Contributor

@bl-ue Please refrain from pinging individuals who are not involved in the PR or issue you're working in.

Thanks for opening a PR with these fixes! I believe the only official problem was the translation files, but we also have a lot of autogenerated content in our REST and GraphQL that we need to change internally. I'll chat with the team and figure out the best solution here.

@bl-ue
Copy link
Contributor Author

bl-ue commented Jun 19, 2021

Please refrain from pinging individuals who are not involved in the PR or issue you're working in.

I'm sorry @janiceilene — I just wanted to make sure that I wasn't being ignored because you saw that changes were requested. I'll keep that in mind.

but we also have a lot of autogenerated content in our REST and GraphQL that we need to change internally.

Ah, great point.

I'll chat with the team and figure out the best solution here.

Thank you! :)

@janiceilene
Copy link
Contributor

👋 @bl-ue Can you remove the translated files from this PR? Let me know when that's done and I'll get this up for review.

@bl-ue
Copy link
Contributor Author

bl-ue commented Jun 23, 2021

Done @janiceilene. I saved the old branch locally in case we need it.

@janiceilene janiceilene added waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jun 23, 2021
Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing these typos 😉

@mchammer01 mchammer01 dismissed github-actions[bot]’s stale review June 24, 2021 08:13

Taken care of by PR author

@mchammer01 mchammer01 merged commit 31c5034 into github:main Jun 24, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@bl-ue bl-ue deleted the fix-typos branch June 24, 2021 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants