-
Notifications
You must be signed in to change notification settings - Fork 65.4k
Update forming-calls-with-graphql.md #7546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Several external links at the bottom have changed. This update avoid a redirection.
janiceilene
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for opening a PR with this update @pberthonneau! I committed a few suggestions to link to the same header we were previously linking to. Could you update the last link to avoid the redirect, as well?
Let me know when that's done and I'll get this merged ⚡
|
|
||
| * [Pagination](https://graphql.github.io/learn/pagination/) | ||
| * [Pagination](https://graphql.org/learn/pagination/) | ||
| * [Fragments](https://graphql.github.io/learn/queries/#fragments) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you're making these great changes, could you update this one to https://graphql.org/learn/queries/#fragments as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! I must have been tired.
janiceilene
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome @pberthonneau! Thanks so much for taking the time to open a PR and then update it 💖 I'll update the branch and get this merged once tests are passing 🍏
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Several external links at the bottom have changed.
This update avoid a redirection.
Why:
Closes [issue link]
What's being changed:
Check off the following:
Writer impact (This section is for GitHub staff members only):