Skip to content

Conversation

@pberthonneau
Copy link
Contributor

Several external links at the bottom have changed.
This update avoid a redirection.

Why:

Closes [issue link]

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

Several external links at the bottom have changed.
This update avoid a redirection.
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jun 21, 2021
Copy link
Contributor

@janiceilene janiceilene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for opening a PR with this update @pberthonneau! I committed a few suggestions to link to the same header we were previously linking to. Could you update the last link to avoid the redirect, as well?

Let me know when that's done and I'll get this merged ⚡


* [Pagination](https://graphql.github.io/learn/pagination/)
* [Pagination](https://graphql.org/learn/pagination/)
* [Fragments](https://graphql.github.io/learn/queries/#fragments)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're making these great changes, could you update this one to https://graphql.org/learn/queries/#fragments as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! I must have been tired.

@github github deleted a comment Jun 22, 2021
@github github deleted a comment Jun 23, 2021
@github github deleted a comment Jun 23, 2021
@github github deleted a comment Jun 23, 2021
@github github deleted a comment Jun 23, 2021
@github github deleted a comment Jun 23, 2021
@github github deleted a comment Jun 23, 2021
Copy link
Contributor

@janiceilene janiceilene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome @pberthonneau! Thanks so much for taking the time to open a PR and then update it 💖 I'll update the branch and get this merged once tests are passing 🍏

@github github deleted a comment Jun 23, 2021
@janiceilene janiceilene merged commit 9d3f0b2 into github:main Jun 23, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage Do not begin working on this issue until triaged by the team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants