Skip to content

Conversation

@jsoref
Copy link
Contributor

@jsoref jsoref commented Jun 23, 2021

Why:

The current text isn't grammatically sound and is effectively meaningless / confusing / etc.

closes #7416

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jun 23, 2021
Copy link
Contributor

@janiceilene janiceilene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks great @jsoref! Thanks so much for opening a PR with the fix ✨ I'll update the branch and get this merged once tests are passing 🍏

@janiceilene janiceilene added the ready to merge This pull request is ready to merge label Jun 23, 2021
@felicitymay felicitymay enabled auto-merge (squash) June 24, 2021 06:47
@felicitymay felicitymay merged commit 5e50abc into github:main Jun 24, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@jsoref jsoref deleted the issues/7416 branch June 24, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge This pull request is ready to merge triage Do not begin working on this issue until triaged by the team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Job status check functions sentence is broken

3 participants