Skip to content

fix: correct firewall log paths in smoke-copilot workflow#122

Closed
Copilot wants to merge 2 commits intomainfrom
copilot/fix-log-parsing-issue
Closed

fix: correct firewall log paths in smoke-copilot workflow#122
Copilot wants to merge 2 commits intomainfrom
copilot/fix-log-parsing-issue

Conversation

Copy link
Contributor

Copilot AI commented Dec 19, 2025

Firewall step summary was not being generated because log paths were misaligned across three locations in the workflow.

Problem

  • Artifact upload expects: /tmp/gh-aw/sandbox/firewall/logs/
  • Parser was looking at: /tmp/gh-aw/squid-logs-${sanitizedName}/
  • awf writes logs to: /tmp/squid-logs-<timestamp>/

Changes

  • Add squid log relocation — Move logs from /tmp/squid-logs-* to /tmp/gh-aw/sandbox/firewall/logs/ before upload (mirrors existing agent log handling)
  • Fix parser path — Point to /tmp/gh-aw/sandbox/firewall/logs/ to match artifact upload location
  • Remove dead code — Delete unused sanitizeWorkflowName function
# New log relocation block (follows existing agent logs pattern)
SQUID_LOGS_DIR="$(find /tmp -maxdepth 1 -type d -name 'squid-logs-*' -print0 2>/dev/null | xargs -0 -r ls -td 2>/dev/null | head -1)"
if [ -n "$SQUID_LOGS_DIR" ] && [ -d "$SQUID_LOGS_DIR" ]; then
  sudo mkdir -p /tmp/gh-aw/sandbox/firewall/logs/
  sudo mv "$SQUID_LOGS_DIR"/* /tmp/gh-aw/sandbox/firewall/logs/ || true
fi
Original prompt

This section details on the original issue you should resolve

<issue_title>Log parsing is not working</issue_title>
<issue_description>No step summary for firewall in this run although an artifact is present.

https://github.com/githubnext/gh-aw/actions/runs/20140062410/job/57804649396</issue_description>

<agent_instructions>investigate and fix</agent_instructions>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix log parsing issue for firewall run fix: correct firewall log paths in smoke-copilot workflow Dec 19, 2025
Copilot AI requested a review from Mossaka December 19, 2025 09:11
@Mossaka Mossaka added the smoke label Dec 19, 2025
@github-actions
Copy link

📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing...

@github-actions
Copy link

💥 WHOOSH! Smoke Claude springs into action on this pull request! [Panel 1 begins...]

@Mossaka Mossaka marked this pull request as ready for review December 19, 2025 17:52
@github-actions
Copy link

Smoke Test Results

Last 2 Merged PRs:

Test Results:

  • ✅ GitHub MCP Testing (reviewed PRs)
  • ✅ File Writing Testing (created /tmp/gh-aw/agent/smoke-test-copilot-20378123949.txt)
  • ✅ Bash Tool Testing (verified file contents)

Status: PASS

📰 BREAKING: Report filed by Smoke Copilot fer issue #122 🗺️

@github-actions
Copy link

Smoke Test Results

Last 2 merged PRs:

Test Results:

  • ✅ GitHub MCP: Retrieved PR titles
  • ✅ File Write: Created test file successfully
  • ✅ Bash Tool: Verified file contents
  • ❌ Playwright MCP: Page loaded but tunnel connection errors

Overall: FAIL (Playwright connectivity issue)

💥 [THE END] — Illustrated by Smoke Claude fer issue #122 🗺️

@github-actions
Copy link

github-actions bot commented Dec 19, 2025

Test Coverage Report

Metric Coverage Covered/Total
Lines 66.1% 708/1071
Statements 66.27% 729/1100
Functions 70.73% 87/123
Branches 60.89% 232/381
Coverage Thresholds

The project has the following coverage thresholds configured:

  • Lines: 38%
  • Statements: 38%
  • Functions: 35%
  • Branches: 30%

Coverage report generated by `npm run test:coverage`

@Mossaka Mossaka closed this Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Log parsing is not working

2 participants