Skip to content

fix: wrap placeholders in backticks in smoke-codex.md#1310

Merged
lpcox merged 2 commits intoclaude/auto-inject-gh-hostfrom
copilot/fix-github-actions-workflow-markdown-lint
Mar 14, 2026
Merged

fix: wrap placeholders in backticks in smoke-codex.md#1310
lpcox merged 2 commits intoclaude/auto-inject-gh-hostfrom
copilot/fix-github-actions-workflow-markdown-lint

Conversation

Copy link
Contributor

Copilot AI commented Mar 14, 2026

Markdown Lint CI was failing because __GH_AW_GITHUB_REPOSITORY__ placeholders in prose were interpreted as underscore-style bold (__text__), violating MD050 which requires asterisk-style bold.

Changes

  • .github/workflows/smoke-codex.md: Wrapped all bare __GH_AW_GITHUB_REPOSITORY__ occurrences in backtick code spans; converted the double-quoted args string to a backtick code span for consistency
-1. **GitHub MCP Testing**: Review the last 2 merged pull requests in __GH_AW_GITHUB_REPOSITORY__
-2. **Safe Inputs GH CLI Testing**: Use the `safeinputs-gh` tool to query 2 pull requests from __GH_AW_GITHUB_REPOSITORY__ (use args: "pr list --repo __GH_AW_GITHUB_REPOSITORY__ --limit 2 --json number,title,author")
+1. **GitHub MCP Testing**: Review the last 2 merged pull requests in `__GH_AW_GITHUB_REPOSITORY__`
+2. **Safe Inputs GH CLI Testing**: Use the `safeinputs-gh` tool to query 2 pull requests from `__GH_AW_GITHUB_REPOSITORY__` (use args: `pr list --repo __GH_AW_GITHUB_REPOSITORY__ --limit 2 --json number,title,author`)

Code spans are not parsed for inline markdown formatting, so the __ delimiters are treated as literal characters. The placeholders are still substituted at runtime by substitute_placeholders.cjs as before.

Original prompt

Fix the failing GitHub Actions workflow Markdown Lint
Analyze the workflow logs, identify the root cause of the failure, and implement a fix.
Job ID: 67092043862
Job URL: https://github.com/github/gh-aw-firewall/actions/runs/23097349950/job/67092043862


💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Copilot AI changed the title [WIP] [67092043862] Fix failing GitHub Actions workflow Markdown Lint fix: wrap placeholders in backticks in smoke-codex.md Mar 14, 2026
Copilot AI requested a review from lpcox March 14, 2026 22:13
@github-actions
Copy link
Contributor

Smoke test results:
PR titles: #1309 fix: match case-insensitive AWF binary step name in postprocessor; #1307 fix: make smoke-codex instructions clearly identifiable as workflow task for Codex model

  1. GitHub MCP review: ✅
  2. safeinputs-gh PR query: ❌
  3. Playwright title contains "GitHub": ✅
  4. Tavily search results returned: ❌
  5. File write (/tmp/gh-aw/agent/smoke-test-codex-23097465964.txt): ✅
  6. Bash cat verification: ✅
  7. Discussion query + oracle comment: ❌
  8. npm ci && npm run build: ✅
    Overall status: FAIL

🔮 The oracle has spoken through Smoke Codex

Warning

⚠️ Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

  • ab.chatgpt.com
  • registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "ab.chatgpt.com"
    - "registry.npmjs.org"

See Network Configuration for more information.

@github-actions
Copy link
Contributor

🏗️ Build Test Suite Results

Ecosystem Project Build/Install Tests Status
Bun elysia 1/1 passed ✅ PASS
Bun hono 1/1 passed ✅ PASS
C++ fmt N/A ✅ PASS
C++ json N/A ✅ PASS
Deno oak N/A 1/1 passed ✅ PASS
Deno std N/A 1/1 passed ✅ PASS
.NET hello-world N/A ✅ PASS
.NET json-parse N/A ✅ PASS
Go color 1/1 passed ✅ PASS
Go env 1/1 passed ✅ PASS
Go uuid 1/1 passed ✅ PASS
Java gson 1/1 passed ✅ PASS
Java caffeine 1/1 passed ✅ PASS
Node.js clsx All passed ✅ PASS
Node.js execa All passed ✅ PASS
Node.js p-limit All passed ✅ PASS
Rust fd 1/1 passed ✅ PASS
Rust zoxide 1/1 passed ✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Generated by Build Test Suite for issue #1310 ·

@lpcox lpcox marked this pull request as ready for review March 14, 2026 22:20
@lpcox lpcox requested a review from Mossaka as a code owner March 14, 2026 22:20
Copilot AI review requested due to automatic review settings March 14, 2026 22:20
@lpcox lpcox merged commit 7e491b0 into claude/auto-inject-gh-host Mar 14, 2026
26 checks passed
@lpcox lpcox deleted the copilot/fix-github-actions-workflow-markdown-lint branch March 14, 2026 22:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes MarkdownLint CI failures in the Codex smoke workflow instructions by preventing __GH_AW_*__ placeholders from being parsed as underscore-based bold, keeping the workflow body compliant with MD050.

Changes:

  • Wrapped __GH_AW_GITHUB_REPOSITORY__ placeholders in inline code spans so __ is treated literally.
  • Converted the GH CLI args example from a quoted string to an inline code span for consistent formatting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

lpcox added a commit that referenced this pull request Mar 14, 2026
…1305)

* Initial plan

* feat(cli): auto-inject GH_HOST from GITHUB_SERVER_URL

- Add extractGhHostFromServerUrl() helper to extract hostname from GITHUB_SERVER_URL
- Auto-inject GH_HOST env var in agent container when GHES/GHEC detected
- Add comprehensive unit tests for extractGhHostFromServerUrl()
- Add integration tests for GH_HOST auto-injection
- Ensures gh CLI inside agent container targets correct GitHub instance

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

* docs: add GH_HOST auto-injection documentation

- Document automatic GH_HOST environment variable injection
- Update GHEC and GHES configuration sections
- Explain how GH_HOST ensures gh CLI targets correct instance

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

* fix: make smoke-codex instructions clearly identifiable as workflow task for Codex model (#1307)

* Initial plan

* fix: make smoke-codex instructions clearly identifiable as workflow task for Codex model

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

* fix: match case-insensitive AWF binary step name in postprocessor (#1309)

* Initial plan

* fix: match case-insensitive AWF binary step name in postprocessor

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

* fix: wrap placeholders in backticks in smoke-codex.md (#1310)

* Initial plan

* fix: wrap placeholders in backticks in smoke-codex.md

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

---------

Co-authored-by: anthropic-code-agent[bot] <242468646+Claude@users.noreply.github.com>
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Co-authored-by: Landon Cox <landon.cox@microsoft.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants